Add new "Publishing" sheet #24855
Add new "Publishing" sheet #24855
Conversation
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 29179 | |
| Version | PR #24855 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 9b1648d | |
| Installation URL | 626ujqrtqttj0 |
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 29179 | |
| Version | PR #24855 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 9b1648d | |
| Installation URL | 6qnhqpg5uvslg |
| "postSettings.preview.label", | ||
| value: "Preview", | ||
| comment: "Label for the preview button in Post Settings" | ||
| ) |
There was a problem hiding this comment.
It seems publishingOptionsHeader and previewLabel are not used.
kean
force-pushed
the
task/rework-prepublishing-sheet-ios26
branch
from
277cde3 to
08d261f
Compare
Generated by 🚫 Danger |
|
I made some minor tweaks and integrated social sharing. It now works by updating the existing The only missing piece now is “Media Upload” status integration, which I’ll implement in a separate PR. I’ll continue testing and refining it in separate PRs also – it’s currently under the FF. |
| } | ||
|
|
||
| static func make(for post: Post) -> PostSocialSharingSettings? { | ||
| guard let context = post.managedObjectContext else { |
There was a problem hiding this comment.
I copied most of the social-sharing code from the existing PrepublishingViewController with minimum changes to the implementation or the architecture. I do not plan to rework it in the scope of this project.
kean
force-pushed
the
task/rework-prepublishing-sheet-ios26
branch
from
c4eff4d to
c694e39
Compare
|
I also integrated the media uploads state view. It's not complete. The feature flag is still off for now – I'll enable it when It's fully tested and UI tests are updated. 
|
| } | ||
|
|
||
| private var cornerRadius: CGFloat { | ||
| if #available(iOS 26, *) { 10 } else { 6 } |
There was a problem hiding this comment.
A small change to make the corner radius work better with the larger radius on iOS 26.
| /// - parameter changes: The set of changes apply to the post together | ||
| /// with the publishing options. | ||
| @MainActor | ||
| func publish_v2(_ post: AbstractPost, parameters: RemotePostUpdateParameters) async throws { |
There was a problem hiding this comment.
I plan to remove the previous version in the next PR where the legacy screen is removed.
| slug = post.wp_slug ?? "" | ||
| status = post.status ?? .draft | ||
| publishDate = post.dateCreated | ||
| publishDate = post.shouldPublishImmediately() ? nil : post.dateCreated |
There was a problem hiding this comment.
Lore: #23333 (comment)
| delegate: self, | ||
| coreDataStack: ContextManager.shared | ||
| ) | ||
| viewController?.navigationController?.pushViewController(optionsVC, animated: true) |
There was a problem hiding this comment.
It's not ideal, but it's the existing practice in this screen, and I'm not planning to refactor it in this PR.
kean
force-pushed
the
task/rework-prepublishing-sheet-ios26
branch
from
79082ea to
9b1648d
Compare
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Issues attributed to commits in this pull requestThis pull request was merged and Sentry observed the following issues:
|
Fixes https://linear.app/a8c/issue/CMM-759/new-publishing-sheet. See the ticket for the rationale.
Changes:
In terms of tech, it now uses the existing
PostSettingsViewwith minimum changes – only adding the header and the “publish” logic. Any change we add to “Post Settings” – like adding “Excerpt“ generator – is automatically reflected here. It even reuses the existingSiteListRowViewnow.For simplicity, it’s just a variation of
PostSettingsViewModel– it’s nearly identical, and in the future I plan to add the “Status” field to “Post Settings” to be consistent with the web an dot allow publishing from “Post Settings” by changing status.Recording
Screen.Recording.2025-09-23.at.8.53.05.AM.mov