Skip to content

Conversation

jkmassel
Copy link
Contributor

@jkmassel jkmassel commented Sep 17, 2025

Description

Fixes a bunch of different warnings that surfaced in Xcode 26.

Testing instructions

If CI passes, we're good to go.

@dangermattic
Copy link
Collaborator

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@jkmassel jkmassel force-pushed the fix/xcode-26-warnings branch from 2480e2f to a66ed1c Compare September 17, 2025 21:47
Copy link

@wpmobilebot
Copy link
Contributor

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number29042
VersionPR #24856
Bundle IDorg.wordpress.alpha
Commita66ed1c
Installation URL0h2pv8fcl4r20
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Contributor

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number29042
VersionPR #24856
Bundle IDcom.jetpack.alpha
Commita66ed1c
Installation URL09biokgbmqkfg
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

public override init() {
super.init()

webView.configuration.processPool = context.processPool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kean would know more about the details. But I think the intention is reusing this WKProcessPool instance to speed up rendering. So, I don't think we should remove this line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WKProcessPool is deprecated now – Apple says it doesn't actually do anything

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does say "has no effect", so it should be OK to remove. I hope it doesn't negatively affect the performance, but I don't think we've seen any issues in Comments. They do load asynchronously, but it doesn't negatively affect the user experience in a sigifincant way.

Copy link
Contributor

@kean kean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing these! I dream of the day when there are no warnings.

@jkmassel jkmassel added this pull request to the merge queue Sep 18, 2025
Merged via the queue into trunk with commit f693ae8 Sep 18, 2025
30 of 32 checks passed
@jkmassel jkmassel deleted the fix/xcode-26-warnings branch September 18, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants