-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix Xcode 26 Warnings #24856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Xcode 26 Warnings #24856
Conversation
Generated by 🚫 Danger |
Full warning: > MediaProgressCoordinator.swift:54:128 Forming 'UnsafeMutableRawPointer' to an inout variable of type String exposes the internal representation rather than the string contents.
> Creating and using multiple instances of WKProcessPool no longer has any effect
2480e2f
to
a66ed1c
Compare
|
|
App Name | WordPress | |
Configuration | Release-Alpha | |
Build Number | 29042 | |
Version | PR #24856 | |
Bundle ID | org.wordpress.alpha | |
Commit | a66ed1c | |
Installation URL | 0h2pv8fcl4r20 |
|
App Name | Jetpack | |
Configuration | Release-Alpha | |
Build Number | 29042 | |
Version | PR #24856 | |
Bundle ID | com.jetpack.alpha | |
Commit | a66ed1c | |
Installation URL | 09biokgbmqkfg |
public override init() { | ||
super.init() | ||
|
||
webView.configuration.processPool = context.processPool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kean would know more about the details. But I think the intention is reusing this WKProcessPool
instance to speed up rendering. So, I don't think we should remove this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WKProcessPool
is deprecated now – Apple says it doesn't actually do anything
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does say "has no effect", so it should be OK to remove. I hope it doesn't negatively affect the performance, but I don't think we've seen any issues in Comments. They do load asynchronously, but it doesn't negatively affect the user experience in a sigifincant way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing these! I dream of the day when there are no warnings.
Description
Fixes a bunch of different warnings that surfaced in Xcode 26.
Testing instructions
If CI passes, we're good to go.