Skip to content

Enable FFs for 26.4 #24906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 1, 2025
Merged

Enable FFs for 26.4 #24906

merged 5 commits into from
Oct 1, 2025

Conversation

kean
Copy link
Contributor

@kean kean commented Sep 30, 2025

Changes:

  • Enable upcoming FFs
  • Fix an issue with onAppear not called in PublishPostView leading to the tags suggestions not being generated

@kean kean added this to the 26.4 milestone Sep 30, 2025
@kean kean requested a review from jkmassel September 30, 2025 20:16
@kean kean added the General label Sep 30, 2025
kean
kean commented Sep 30, 2025
View reviewed changes
WordPress/Classes/Utility/BuildInformation/FeatureFlag.swift
case .intelligence:
return BuildConfiguration.current == .debug
let languageCode = Locale.current.languageCode
return (languageCode ?? "en").hasPrefix("en")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened a ticket to fix and enable it for more locales https://linear.app/a8c/issue/CMM-762/excerpts-are-created-in-the-system-language-not-the-content-language. It needs more work and testing to ensure it performs as expected.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to make it an experimental feature so that users can enable it if they want?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good idea. Done:

Screenshot 2025-10-01 at 7 04 45 AM

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Sep 30, 2025 •
edited
Loading

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number29309
VersionPR #24906
Bundle IDorg.wordpress.alpha
Commit2459457
Installation URL1gu57pfilrf20
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Sep 30, 2025 •
edited
Loading

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number29309
VersionPR #24906
Bundle IDcom.jetpack.alpha
Commit2459457
Installation URL3afcigpk2oo4g
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@kean kean force-pushed the task/enable-ffs branch from 1833d50 to af48371 Compare October 1, 2025 11:01
@kean kean enabled auto-merge October 1, 2025 11:06
@kean kean requested a review from a team as a code owner October 1, 2025 14:45
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.

Generated by 🚫 Danger

@kean
Copy link
Contributor Author

kean commented Oct 1, 2025

I updated the UI tests, and I also took the liberty and reverted the change where "Date" and "Visibility" rows were moved under the "General" section. They now appear at the top in the same order as in the production version. I want to minimize the amount of disruption to the user experience. Everything is in the same place – we just fixed the UX issues and added new features.

Screenshot 2025-10-01 at 10 45 52 AM

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 1, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@kean kean added this pull request to the merge queue Oct 1, 2025
Merged via the queue into trunk with commit 54f2a1b Oct 1, 2025
30 of 32 checks passed
@kean kean deleted the task/enable-ffs branch October 1, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkmassel jkmassel jkmassel approved these changes

Assignees
No one assigned
Labels
General
Projects
None yet
Milestone
26.4 ❄️
Development

Successfully merging this pull request may close these issues.
4 participants
@kean @wpmobilebot @dangermattic @jkmassel