Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Deliverfile related functionality #450

Conversation

iangmaia
Copy link
Contributor

What does it do?

On this discussion I had with @AliSoftware he mentioned that using the Deliverfile to configure the app version became obsolete, so this PR removes all references to it.

It implements:

  • Removal of the include_deliverfile parameter in Ios::GitHelper.commit_version_bump() and all call sites.
  • Removal of the skip_deliver ConfigItem in the actions ios_bump_version_hotfix and ios_bump_version_release.rb.
  • Removal of the method Ios::VersionHelper::update_fastlane_deliver().

Related PRs

Next steps

The idea is that the current Ios::GitHelper.commit_version_bump() will become obsolete, given now all it does is committing the hard-coded /config/ folder. So based on this work, we can also remove Ios::GitHelper.commit_version_bump() and commit the .xcconfig directly from where it's being changed.

Checklist before requesting a review

  • Run bundle exec rubocop to test for code style violations and recommendations
  • Add Unit Tests (aka specs/*_spec.rb) if applicable
  • Run bundle exec rspec to run the whole test suite and ensure all your tests pass
  • Make sure you added an entry in the CHANGELOG.md file to describe your changes under the approprioate existing ### subsection of the existing ## Trunk section.

@AliSoftware AliSoftware self-requested a review February 10, 2023 20:59
@AliSoftware
Copy link
Contributor

@iangmaia With more of your other PRs landing in iangmaia/trial we now have some conflicts that appeared here too 🙃 Can you resolve them and pinging me again once it's ready? Thanks!

@AliSoftware AliSoftware self-assigned this Feb 10, 2023
@iangmaia iangmaia force-pushed the cleanup/remove-deliver-file branch from 4b32ccb to c50166c Compare February 10, 2023 21:17
@iangmaia iangmaia force-pushed the cleanup/remove-deliver-file branch from c50166c to 8eeea65 Compare February 10, 2023 21:54
@iangmaia
Copy link
Contributor Author

@iangmaia With more of your other PRs landing in iangmaia/trial we now have some conflicts that appeared here too 🙃 Can you resolve them and pinging me again once it's ready? Thanks!

Done!

Copy link
Contributor

@AliSoftware AliSoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed as part of iangmaia#3

@AliSoftware AliSoftware merged commit 8f63869 into wordpress-mobile:iangmaia/trial Feb 11, 2023
@iangmaia iangmaia deleted the cleanup/remove-deliver-file branch February 12, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants