Fix prototype_build_details_comment action when used outside FAD context
#642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iangmaia
reviewed
Mar 21, 2025
| metadata['Build Number'] ||= "<code>#{release_info&.build_version}</code>" | ||
| metadata['Version'] ||= "<code>#{release_info&.display_version}</code>" | ||
| metadata[release_info&.os == 'ios' ? 'Bundle ID' : 'Application ID'] ||= "<code>#{release_info&.bundle_id}</code>" | ||
| unless release_info.nil? |
iangmaia
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
While working on updating Tumblr-Android to use the latest
release-toolkitversion13.0.0(internal ref: Tumblr/android#24388), I noticed that the PR comment for the Prototype Build (which uses direct download from S3 and does not use Firebase App Distribution) contained extra rows.Notice the
Build NumberandVersionrows in the table. TheApplication IDis not empty even if this Prototype Build didn't use FAD, because we happen to provide the value for this metadata explicitly though.This PR used TDD to fix the issue:
Checklist before requesting a review
bundle exec rubocopto test for code style violations and recommendations.specs/*_spec.rb) if applicable.bundle exec rspecto run the whole test suite and ensure all your tests pass.CHANGELOG.mdfile to describe your changes under the appropriate existing###subsection of the existing## Trunksection.If applicable, add an entry in theMIGRATION.mdfile to describe how the changes will affect the migration from the previous major version and what the clients will need to change and consider.