Skip to content

[PLAT-5666] Preparing for Rails 8.0 upgrade #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
djezzzl wants to merge 2 commits into from
Closed

[PLAT-5666] Preparing for Rails 8.0 upgrade #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05ecb96
Relax gemspec to support Rails 8.0
djezzzl Oct 27, 2025
e599f4f
Migrate to_s -> to_fs
djezzzl Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/workato/connector/sdk/dsl/csv_package.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class CsvFileTooBigError < CsvError

sig { params(size: Integer, max: Integer).void }
def initialize(size, max)
super("CSV file is too big. Max allowed: #{max.to_s(:human_size)}, got: #{size.to_s(:human_size)}")
super("CSV file is too big. Max allowed: #{max.to_fs(:human_size)}, got: #{size.to_fs(:human_size)}")
Copy link
Author

@djezzzl djezzzl Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though we backport to_s functionallity for a smoother migration, I would still keep these changes.

@size = T.let(size, Integer)
@max = T.let(max, Integer)
end
Expand Down
2 changes: 1 addition & 1 deletion workato-connector-sdk.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ Gem::Specification.new do |spec|

spec.required_ruby_version = '>= 2.7.6'

spec.add_dependency 'activesupport', '>= 5.2', '< 7.1'
spec.add_dependency 'activesupport', '>= 5.2', '< 8.1'
spec.add_dependency 'aws-sigv4', '~> 1.2', '>= 1.2.4'
spec.add_dependency 'bundler', '~> 2.0'
spec.add_dependency 'charlock_holmes', '~> 0.7', '>= 0.7.7'
Expand Down
Loading