Add Rust analyzer support #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Considering that there's soon a release, I wonder if we should merge this PR (after a small clean up). Showing syntax errors is already quite useful, and we could look into diagnostics in a follow-up PR. |
|
Agree - I'll do that and make a follow up for you 😸 |
sonnyp
commented
Feb 11, 2024
src/workbench
Outdated
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| export WEBKIT_DISABLE_DMABUF_RENDERER=1 | |||
| # export G_MESSAGES_DEBUG=@app_id@ | |||
| GSK_RENDERER=gl | |||
There was a problem hiding this comment.
I'm having issues. It's going to be the default soon anyway
lw64
approved these changes
Feb 11, 2024
sonnyp
commented
Feb 11, 2024
| @@ -64,6 +65,7 @@ export function createSessionFromDemo(demo) { | |||
|
|
|||
| const { file, settings } = session; | |||
| copyDirectory(demo_dir, file); | |||
| copyDirectory(rust_template_dir, file); | |||
There was a problem hiding this comment.
This will copy Rust template files such as Cargo.toml and workbench.rs when creating a new session from a demo.
We already do this on compile but if we want diagnostics to work before pressing "Run" we need this here too.
Hofer-Julian
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #520
Only supports syntax diagnostics for now. I made a follow up for types #881
How to test
Diagnostics will appear for syntax errors.