Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add DidChangeAttrs mixin #2

Merged
merged 2 commits into from
Oct 31, 2017
Merged

add DidChangeAttrs mixin #2

merged 2 commits into from
Oct 31, 2017

Conversation

GavinJoyce
Copy link
Collaborator

@GavinJoyce GavinJoyce commented Oct 31, 2017

see workmanw/ember-diff-attrs#4 for discussion on the why

closes #1
closes workmanw/ember-diff-attrs#4

TODO:

  • Support custom isEqual function

For subsequent PRs:

@GavinJoyce GavinJoyce changed the title [WIP] add DidChangeAttrs mixin add DidChangeAttrs mixin Oct 31, 2017
@GavinJoyce
Copy link
Collaborator Author

GavinJoyce commented Oct 31, 2017

/cc @workmanw

This is ready for review. I'm purposefully keeping this simple for now as I'd like to try this out in my app before settling on the API and building out additional features like supporting inheritence

@GavinJoyce GavinJoyce merged commit 91ac2a6 into master Oct 31, 2017
@GavinJoyce GavinJoyce deleted the gj/inital branch October 31, 2017 21:08
@GavinJoyce
Copy link
Collaborator Author

merging so that I can release a version to test in my own app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement this! Supporting didUpdateAttrs
1 participant