Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get_user, list_users, and delete_user methods #215

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

blairworkos
Copy link
Contributor

Description

Updates the get_user, list_users, and delete_user methods to match the current User Management API.

Documentation

Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.

[ ] Yes

If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.

@blairworkos blairworkos self-assigned this Nov 15, 2023
@blairworkos blairworkos requested a review from a team as a code owner November 15, 2023 16:06
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9c5b744) 87.72% compared to head (bfc3dff) 87.72%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #215   +/-   ##
=======================================
  Coverage   87.72%   87.72%           
=======================================
  Files          32       32           
  Lines        1157     1157           
=======================================
  Hits         1015     1015           
  Misses        142      142           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -179,19 +179,19 @@ def test_list_users_returns_metadata(

users = self.user_management.list_users(
email="[email protected]",
organization="foo-corp.com",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooh boy we misunderstood this param haha 🤦‍♀️

@blairworkos blairworkos merged commit b53af30 into main Nov 15, 2023
6 checks passed
@blairworkos blairworkos deleted the fix-get-users-list-users-and-delete-users branch November 15, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants