feat(stepper_motor): initial drv8434 driver #120
Draft
+839
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sri9311
changed the title
fouge
changed the title
|
hey |
fouge
changed the title
fouge
force-pushed
the
main
branch
2 times, most recently
from
0974d92 to
52ec901
Compare
fouge
reviewed
Jan 28, 2025
Comment on lines
73
to
87
| uint16_t tx_word = 0; | ||
|
|
||
| // Load register address into tx word | ||
| tx_word = | ||
| tx_word | ((uint16_t)(address) << DRV8434_SPI_TX_ADDRESS_START_POS); | ||
|
|
||
| // Load data into tx word | ||
| tx_word = tx_word | (uint16_t)(data); | ||
|
|
||
| // Wipe TX and RX buffers before each operation | ||
| memset(instance->spi.rx_buffer, 0, sizeof(instance->spi.rx_buffer)); | ||
| memset(instance->spi.tx_buffer, 0, sizeof(instance->spi.tx_buffer)); | ||
|
|
||
| instance->spi.tx_buffer[0u] = (tx_word >> 8) & DRV8434_SPI_TX_LSB_MASK; | ||
| instance->spi.tx_buffer[1u] = tx_word & DRV8434_SPI_TX_LSB_MASK; |
There was a problem hiding this comment.
what about?
seems overly complicated to me 🤔
Suggested change
| uint16_t tx_word = 0; | |
| // Load register address into tx word | |
| tx_word = | |
| tx_word | ((uint16_t)(address) << DRV8434_SPI_TX_ADDRESS_START_POS); | |
| // Load data into tx word | |
| tx_word = tx_word | (uint16_t)(data); | |
| // Wipe TX and RX buffers before each operation | |
| memset(instance->spi.rx_buffer, 0, sizeof(instance->spi.rx_buffer)); | |
| memset(instance->spi.tx_buffer, 0, sizeof(instance->spi.tx_buffer)); | |
| instance->spi.tx_buffer[0u] = (tx_word >> 8) & DRV8434_SPI_TX_LSB_MASK; | |
| instance->spi.tx_buffer[1u] = tx_word & DRV8434_SPI_TX_LSB_MASK; | |
| instance->spi.tx_buffer[0u] = address << 1; | |
| instance->spi.tx_buffer[1u] = data; |
sri9311
force-pushed
the
sri/motor-driver-drv8434
branch
from
8c22185 to
3d38424
Compare
drv8434 register structs and addresses Signed-off-by: Srikar Chintapalli <[email protected]>
drv8434 runtime context structs Signed-off-by: Srikar Chintapalli <[email protected]>
drv8434 defines, application and SPI frame Signed-off-by: Srikar Chintapalli <[email protected]>
drv8434 SPI transaction layer Signed-off-by: Srikar Chintapalli <[email protected]>
drv8434 application interface Signed-off-by: Srikar Chintapalli <[email protected]>
sri9311
force-pushed
the
sri/motor-driver-drv8434
branch
from
3d38424 to
f01a485
Compare
dts file changes to add peripheral support for motor driver Signed-off-by: Srikar Chintapalli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
draft of interface driver to motor driver.
stepper application and integration to follow
fixes ORBP-286