fix(dfu): buffer overflow #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When loading dfu data, if the block_count was larger than what the partition can accept, the processing thread would exit with an error without resetting its internal `dfu_state`, and thus the `wr_idx`. This allowed to write after the buffer boundaries. Internal state is now reset, and wr_idx and data size always checked before writing the buffer. Unit tests have been added to validate DFU logic, including valid and edge case scenarios for sequencing, buffer integrity, and semaphore handling. Signed-off-by: Cyril Fougeray <[email protected]>
fouge
force-pushed
the
fouge/fix-dfu-buffer-overflow
branch
from
98216fe to
7d538c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading dfu data, if the block_count was larger than what the partition can accept, the processing thread would exit with an error without resetting its internal
dfu_state, and thus thewr_idx. This allowed to write after the buffer boundaries.Internal state is now reset, and wr_idx and data size always checked before writing the buffer.
Unit tests have been added to validate DFU logic, including valid and edge case scenarios for sequencing, buffer integrity, and semaphore handling.
fixes SEC-1325