Handle governor warnings similarly to NTT queue #2831
Conversation
👷 Deploy request for wormhole-connect pending review.Visit the deploys page to approve it
|
👷 Deploy request for wormhole-connect-mainnet pending review.Visit the deploys page to approve it
|
| />, | ||
| ); | ||
| } | ||
|
|
||
| for (const warning of quote?.warnings || []) { |
| props.chain ? `to ${props.chain} ` : '' | ||
| }may be delayed due to rate limits set by ${ | ||
| props.token | ||
| }. If your transfer is delayed, you will need to return after ${duration} to complete the transfer. Please consider this before proceeding.`} |
There was a problem hiding this comment.
If this is an AutomaticTokenBridge transfer and it gets delayed by the governor, the transfer will be relayed once the VAA is emitted 24 hours later. The user doesn't need to return to complete it manually.
There was a problem hiding this comment.
I think this copy is ok. Might be too complicated/confusing to have different copy for manual and automatic.
There was a problem hiding this comment.
I think the text should say "after at most 24 hours", because enough room may free up in the rolling window before 24h (unless the tx is over the big tx limit but I guess we don't need to complicate this iteration)
as for later, I believe Wormholescan is able to supply the ETA when a tx is scheduled to be released so future iterations can provide better UX by telling the user how much they'll need to wait.
There was a problem hiding this comment.
imo having a clear and consistent expectation (24 hours) even if its conservative is better than something that is not. As a user, I would be fine just checking back exactly the next day and seeing it done one time, vs thinking it might be done less than 24 hours and repeatedly checking in at random times throughout the day to be disappointed. If it happens to be done sooner and I check in sooner, great, then expectations underpromised overdelivered.
|
@emreboga for governor warnings or NTT warnings, would these show up as history as "in-progress"? Or in the widget as well? |
Addresses #2830
Adapts the existing transfer delay warning logic to also cover
GovernorLimitWarningwith a hard-coded 24 hour period.