Refactor: use SDK amount.Amount type to store token amounts
#2868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for wormhole-connect pending review.Visit the deploys page to approve it
|
👷 Deploy request for wormhole-connect-mainnet pending review.Visit the deploys page to approve it
|
artursapek
force-pushed
the
store-balances-as-sdk-amount
branch
from
12da662
to
fd9ec15
Compare
artursapek
changed the title
amount.Amount type to store balancesamount.Amount type to store token amounts
artursapek
force-pushed
the
store-balances-as-sdk-amount
branch
from
0adb5b5
to
e13a839
Compare
artursapek
force-pushed
the
store-balances-as-sdk-amount
branch
from
e13a839
to
0ce6865
Compare
artursapek
commented
Nov 6, 2024
| [props.routes, props.quotesMap], | ||
| ); | ||
| const allRoutesFailed = useMemo(() => { | ||
| if (Object.keys(props.quotesMap).length === 0) { |
There was a problem hiding this comment.
this fixes a bug unrelated to amount.Amount refactor: if you run every on an empty array, it always returns true.
artursapek
commented
Nov 6, 2024
| @@ -39,7 +39,6 @@ const useFetchSupportedRoutes = (): HookReturn => { | |||
| supported = await route.isRouteSupported( | |||
| token, | |||
| destToken, | |||
| amount, | |||
There was a problem hiding this comment.
this argument was never used by isRouteSupported
kev1n-peters
reviewed
Nov 6, 2024
| @@ -1,37 +0,0 @@ | |||
| import { TransferInfo } from '../utils/sdkv2'; | |||
There was a problem hiding this comment.
Should we delete this file since it's now empty?
There was a problem hiding this comment.
thought I had. thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2853
Changes
Balancetype, andamountvalues in Redux, to store anamount.Amount, not anumberformatAmounthelper function (not required anymore)Overall cleans things up and net removal of code
https://www.loom.com/share/3b0d63df72c04b7182a41e0ca173e9cc