Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix foreign key DungeonMap::ParentWorldMapID incorrectly pointing to AreaTable::ID instead of WorldMapArea::ID #181

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

iTob191
Copy link
Contributor

@iTob191 iTob191 commented Jun 20, 2024

Fix foreign key DungeonMap::ParentWorldMapID incorrectly pointing to AreaTable::ID instead of WorldMapArea::ID.

Sources

  1. https://trinitycore.info/en/files/DBC/335/dungeonmap
  2. Simply looking at the data.
    Example: Icecrown citadel (MapID=631) lists 492 as ParentWorldMapID. 492 in AreaTable::ID is Raven Hill Cemetery in Duskwood while 492 in WorldMapArea::ID is IcecrownGlacier

@Marlamin Marlamin merged commit 36735fc into wowdev:master Jun 20, 2024
1 check passed
@Marlamin
Copy link
Collaborator

Thanks!

@iTob191 iTob191 deleted the patch-1 branch June 20, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants