Add URL rewriting support #98
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
force-pushed
the
fix/97-rewrite-urls
branch
2 times, most recently
from
5e9ad9c to
2e6607d
Compare
|
FYI @adamziel |
swissspidy
force-pushed
the
fix/97-rewrite-urls
branch
from
2e6607d to
16327a1
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
This is great @swissspidy ❤️ |
adamziel
approved these changes
Oct 8, 2025
adamziel
reviewed
Oct 8, 2025
| $GLOBALS['wpcli_import_current_file'] = basename( $file ); | ||
| $wp_import->import( $file ); | ||
|
|
||
| $reflection = new \ReflectionMethod( $wp_import, 'import' ); |
There was a problem hiding this comment.
Should we expose the version number from the plugin to make this easier? I guess this is still safer since, theoretically, that argument may be removed in a future plugin version — although I don't expect that to ever happen as it would break the bc.
There was a problem hiding this comment.
Yeah I think the current method is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #97