Dump a new autoloader when generating a Phar #256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
swissspidy
force-pushed
the
add/phar-dump-autoload
branch
from
464ac60 to
7058e4a
Compare
swissspidy
commented
May 8, 2025
swissspidy
commented
May 8, 2025
swissspidy
force-pushed
the
add/phar-dump-autoload
branch
from
7058e4a to
25f4f70
Compare
|
@schlessera would love to hear especially your thoughts on this situation & solution. |
schlessera
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to the remaining failing Behat tests when code coverage is running.
Basically what happens in the wp-cli-bundle repo is that we include the autoloader once in
generate-coverage.php, and then in the generated Phar the same autoloader is included again. That causes a fatal error because the sameComposerAutoloaderInit...class is declared twice.This PR addresses this by temporarily changing the autoloader class suffix for that generated Phar. Requires otherwise using a hardcoded suffix (instead of the default
content-hash). See wp-cli/wp-cli-bundle#764 for that.Requires the PHP 7.2 bump, see wp-cli/wp-cli-bundle#760
See Slack discussion for additional context