Skip to content

Add ability to specify minimum mysql version requirement #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jul 28, 2025
Merged

Add ability to specify minimum mysql version requirement #266

merged 12 commits into from
Jul 28, 2025

Conversation

michaelw85
Copy link
Contributor

Added for #198 to allow skipping mysql 5.6

@michaelw85 michaelw85 requested a review from a team as a code owner July 25, 2025 10:09
@michaelw85 michaelw85 mentioned this pull request Jul 25, 2025
Merged
@codecov Codecov
Copy link

codecov bot commented Jul 25, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/Context/GivenStepDefinitions.php 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@swissspidy
Copy link
Member

I like the suggestion in general 👍

For completeness, do we need the same for mariadb and for less-than-* too?

Some tests in TestBehatTags.php would be helpful to see that it works.

@michaelw85
Copy link
Contributor Author

@swissspidy I've updated the code, maria db and mysql now support a minimum and less than tag! 🥳

swissspidy
swissspidy reviewed Jul 25, 2025
View reviewed changes
swissspidy
swissspidy reviewed Jul 25, 2025
View reviewed changes
Copy link
Member

@swissspidy swissspidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just one question, otherwise seems like a good addition!

swissspidy
swissspidy approved these changes Jul 28, 2025
View reviewed changes
Copy link
Member

@swissspidy swissspidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@swissspidy swissspidy added this to the 5.0.1 milestone Jul 28, 2025
@swissspidy swissspidy merged commit ce7412d into wp-cli:main Jul 28, 2025
51 checks passed
@michaelw85 michaelw85 deleted the add_mysql_version_tags branch July 28, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swissspidy swissspidy swissspidy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelw85 @swissspidy