🎯 Tracking: Resolving nodes by URI

[justlevine]

This is a tracker for all the issues with bad/missing results when resolving nodes by their URI.

The general problem stems from NodeResolver's attempt to replicate WP::parse_request with a provided uri. Assumingly, some of these are due to misordered conditionals, while others are missing edge cases.

Proposed Work

As I see it, the ideal solve requires 3 steps:

• Refactor NodeResolver to make the code less complex, and easier to test/iterate on. ( chore: clean up and add comments to NodeResolver::resolve_uri() conditional logic. #2656 )
• Add missing wpunit tests to NodeByUriTest to bring NodeResolver::resolve_uri() to 100%. ( test: backfill nodeByUri query testing #2659 )
• Fix existing bugs in resolver ( feat: Refactor NodeResolver::resolve_uri() to use WP_Query #2680 )
• Research and add support for other edge cases, using the issues below as a baseline.

Tracking:

• bug: fetching translated posts by uri #2066
• Receiving wrong contentType when idType is set to URI #1850
• nodeByUri does not return ContentType for Posts Page. #1687
• Querying non-existent single page by URI returns error instead of null #1639
• Post Format archives don't resolve with nodeByUri query #2190
• NodeByUri not resolving properly for media items #2178
• NodeByUri will not query WooCommerce products since v1.8.1 #2394
• URI inputs should sanitize anchor links from uris #1712
• Can't query /shop/ page by contentNode with uri argument when woocommerce is enabled (no wp-graphql-woocommerce required) #1910
• Querying for preview via asPreview argument doesn't work when querying by slug, uri idTypes #1673
• On ContentType union in nodeByUri returns incorrect isPostsPage #2514
• Date Archives don't resolve with nodeByUri queries #2191

If I missed an issue or if you have a use case not referenced by an existing issue, please share and I'll add it to the tracker.

[ghost]

@justlevine I just opened #2394 that could be added here I think.

[Ririshi]

A discussion thread I opened (#2714) falls under this category as well, as was pointed out by @justlevine.

[justlevine]

Update: most the issues tracked have been resolved as of v1.14.0.

• Date Archives don't resolve with nodeByUri queries #2191 is blocked by Introduce Archive Interfaces #2491
• isFrontPage on ContentType does not return a proper response #2513 and On ContentType union in nodeByUri returns incorrect isPostsPage #2514 need to be revalidated to see if the use of the new WP_Query handling in v1.14.0 resolved the issue tangentially.
• New post doesn't show unless the permalink field is touched #2392 might be invalid as native WP behavior.

[justlevine]

Closing this out, as #2514 is only bug left on this list (as #2191 is more of an enhancement via #2491 at this point). Between that and the Issue Triage project sheet, this ticket is unnecessary for tracking progress/providing context.