Skip to content

Node Resolver

Closed Nov 14, 2023 91% complete

This is a tracker for all the issues with bad/missing results when resolving nodes by their URI.

The general problem stems from NodeResolver's attempt to replicate WP::parse_request with a provided uri. Assumingly, some of these are due to misordered conditionals, while others are missing edge cases.

Proposed Work

As I see it, the ideal solve requires 3 s…

This is a tracker for all the issues with bad/missing results when resolving nodes by their URI.

The general problem stems from NodeResolver's attempt to replicate WP::parse_request with a provided uri. Assumingly, some of these are due to misordered conditionals, while others are missing edge cases.

Proposed Work

As I see it, the ideal solve requires 3 steps:

  • #2342 Refactor NodeResolver to make the code less complex, and easier to test/iterate on.
  • Add missing wpunit tests to NodeByUriTest to bring NodeResolver::resolve_uri() to 100%.
  • Research and add support for other edge cases, using the issues below as a baseline.

Tracking:

If I missed an issue or if you have a use case not referenced by an existing issue, please share and I'll add it to the tracker.

Loading