Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #7281: Preload Fonts - Current feature deprecation #7317

Open
wants to merge 2 commits into
base: feature/preload-fonts
Choose a base branch
from

Conversation

Miraeld
Copy link
Contributor

@Miraeld Miraeld commented Feb 21, 2025

Description

Fixes #7281
Removes the old UI of Preload Fonts

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as before).

Detailed scenario

Browse the preload settings, you won't see the old preload fonts in it.

Technical description

Documentation

This pull request includes significant changes to the inc/Engine/Admin/Settings/Page.php and inc/Engine/Admin/Settings/Settings.php files, primarily focusing on the removal of the font preloading feature from the settings page and related sanitization functions. Additionally, corresponding test cases have been removed from the test files.

Removal of font preloading feature:

Removal of related test cases:

New dependencies

None

Risks

None

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

@Miraeld Miraeld requested a review from a team February 21, 2025 02:27
@Miraeld Miraeld self-assigned this Feb 21, 2025
@Miraeld Miraeld linked an issue Feb 21, 2025 that may be closed by this pull request
Copy link

codacy-production bot commented Feb 21, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.02% (target: -0.10%) 0.00% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (045ea4a) 39430 17232 43.70%
Head commit (d0b83dd) 39372 (-58) 17197 (-35) 43.68% (-0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#7317) 1 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.19 - Preload Fonts - Current feature deprecation
1 participant