Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wpiutil[sendable] include add property overloads without setter argument. #7148

Closed
wants to merge 2 commits into from

Conversation

narmstro2020
Copy link
Contributor

This PR provides default overloads to the add property methods such as addIntegerProperty, addBooleanProperty, etc that doesn't require a setter argument. Null is just passed in.

@calcmogul
Copy link
Member

What if the user wants a set-only property?

@narmstro2020
Copy link
Contributor Author

What if the user wants a set-only property?

I was literally thinking about that before sending this, and thought. Well I'm not sure. I'll wait for some feedback.

So shouldn't be any implementation problems here. Just an extra overload for the sender only option. I'm gathering that you are okay with the idea?

@narmstro2020
Copy link
Contributor Author

/format

@PeterJohnson
Copy link
Member

I'm really not a fan of tons of overloads. This class is already too big. There's also a planned rewrite for 2026 (#6453) and the property functions will likely be going away.

@narmstro2020
Copy link
Contributor Author

I'm really not a fan of tons of overloads. This class is already too big. There's also a planned rewrite for 2026 (#6453) and the property functions will likely be going away.

So should I close this PR then?

@PeterJohnson
Copy link
Member

Yes, closing.

@narmstro2020 narmstro2020 deleted the SendableBuilder branch December 26, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants