[wpimath] Fix feedforward returning NaN when kᵥ = 0 #7790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calcmogul
force-pushed
the
wpimath-fix-feedforward-returning-nan-when-kv-eq-0
branch
5 times, most recently
from
6259f74 to
fa5c2d1
Compare
calcmogul
force-pushed
the
wpimath-fix-feedforward-returning-nan-when-kv-eq-0
branch
from
fa5c2d1 to
41dd46b
Compare
PeterJohnson
previously approved these changes
Feb 15, 2025
wpimath/src/main/java/edu/wpi/first/math/controller/ElevatorFeedforward.java
Outdated
Show resolved
Hide resolved
calcmogul
force-pushed
the
wpimath-fix-feedforward-returning-nan-when-kv-eq-0
branch
from
ec32835 to
2077b56
Compare
calcmogul
force-pushed
the
wpimath-fix-feedforward-returning-nan-when-kv-eq-0
branch
from
2077b56 to
34df748
Compare
PeterJohnson
approved these changes
Feb 26, 2025
calcmogul
deleted the
wpimath-fix-feedforward-returning-nan-when-kv-eq-0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.