-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wpical] Refactor to use WPILib libraries, modern C++ conventions, and LGPL libraries #7796
Open
Gold856
wants to merge
16
commits into
wpilibsuite:main
Choose a base branch
from
Gold856:wpical-clean-up
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,748
−1,355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This currently depends on wpilibsuite/thirdparty-ceres#10 being merged. |
calcmogul
reviewed
Feb 17, 2025
919ee3e
to
58153de
Compare
e44f33e
to
77ea8c3
Compare
This means Gradle won't have to generate source files containing the data for these files. Those files were never used at compile time.
…ke variable names clearer
Fixes a bug where trying to cancelling directory selection when combining calibrated field maps would spam open the directory selector
77ea8c3
to
84e8e45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wpical was unable to use wpimath and its dependent libraries because Ceres was compiled with a different version of Eigen. Now that the Ceres build has been redone, we can now use wpimath and our C++ apriltag wrapper in wpical, allowing for major refactors. This includes:
to_json
andfrom_json
specializations to concisely serialize and deserialize all JSON files instead of manually handling JSON.Fieldmap
andPose
classes, which was were duplicates of theAprilTagFieldLayout
andPose3d
classes respectively.AprilTagDetector
instead of the raw libapriltag library.Pose3d
instead of raw Eigen matrices.In addition, several other refactors were made to make the code more readable and to fix several UX issues and crashes. This includes:
std::optional
to indicate a calibration failed instead of status codes.DisplayGui
function into separate functions which contain code for different popups. This also allowed for better organization and scoping of static variables.Fixes #7722.