#41 Fixed As Reported Bug #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Text Domain Trasnlated Missing Words
Added Init Text Domain
JavaScript breaks registration flow for Instamojo Fixed Now
ajitbohra
reviewed
Oct 13, 2017
| @@ -0,0 +1,218 @@ | |||
| /** | |||
| * Give - Razorpay Popup Checkout JS | |||
There was a problem hiding this comment.
Comment needs update "Give" here seems to be irrelevant
| }); | ||
| }); | ||
| /** | ||
| * Give - Razorpay Popup Checkout JS |
There was a problem hiding this comment.
Comment needs update as this is common file for gateways not specific to "Razorypay"
ravinderk
requested changes
Oct 13, 2017
| $form.on('submit', function (e) { | ||
|
|
||
| var phone = $('.mobile').val(); | ||
| console.log(phone); |
There was a problem hiding this comment.
@sanyogs Remove all console.log from code.
ravinderk
requested changes
Oct 13, 2017
| @@ -104,6 +104,26 @@ public function camptix_init() { | |||
| * @access public | |||
| */ | |||
| public function enqueue() { | |||
|
|
|||
| if ( ! isset( $_GET['tix_action'] ) || ( 'attendee_info' !== $_GET['tix_action'] ) ) { | |||
There was a problem hiding this comment.
@sanyogs This code is already in master branch. Did you reformat code or anything else
For ref: https://github.com/wpindiaorg/camptix-indian-payments/blob/master/campt-indian-payment-gateway.php#L177
There was a problem hiding this comment.
I have move required js file for razorpay under razor pay
and common file which is for both validation put in master
coreymckrill
approved these changes
Oct 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Team,
I have fixed the issue #41 which was reported by @coreymckrill
Following things done
Javascript enqueue added seprate file for Razorpay
and common file gateway is seprate with code.
Sanyog Shelar