Jarius - telemetry update (4/5/2022) - #1
Conversation
added new fields
Telemetry Works for updating the following: - relative wind - pitch and roll (updates very slowly) - magnetic heading (current heading)
tnurse18
left a comment
There was a problem hiding this comment.
Looking good! Overall just a few minor things here and there that caught my attention.
| @@ -1,4 +1,11 @@ | |||
| const socket = io(); // socket initialization | |||
| //const socket = io("http://localhost:3000/", { transports: ['polling', 'flashsocket'] }); // socket initialization | |||
There was a problem hiding this comment.
We should keep this. This way we won't need to manually change this IP address every time we use a different one.
There was a problem hiding this comment.
This will be re-implemented using localhost
| <link rel="stylesheet" href="css/foundation.css"> | ||
| <link rel="shortcut icon" href="/assets/favicon.ico" type="image/x-icon"> | ||
| <link rel="icon" href="/assets/favicon.ico" type="image/x-icon"> | ||
| <link rel="shortcut icon" href="../public/assets/favicon.ico" type="image/x-icon"> |
There was a problem hiding this comment.
For a relative path you should be able to do the following where applicable:
| <link rel="shortcut icon" href="../public/assets/favicon.ico" type="image/x-icon"> | |
| <link rel="shortcut icon" href="assets/favicon.ico" type="image/x-icon"> |
| <script type="text/javascript" src="/js/dependencies/d3.min.js" charset="utf-8"></script> | ||
| <script type="text/javascript" src="/js/dependencies/d3gauge.js" charset="utf-8"></script> | ||
| <script type="text/javascript" src="/js/dependencies/FileSaver.min.js" charset="utf-8"></script> | ||
| <script type="text/javascript" src="./js/dependencies/socket.io.min.js"></script> |
There was a problem hiding this comment.
| <script type="text/javascript" src="./js/dependencies/socket.io.min.js"></script> | |
| <script type="text/javascript" src="js/dependencies/socket.io.min.js"></script> |
| <text>Trim Battery:</text> | ||
| </div> | ||
| <div class="values"> | ||
| <text id="voltage">14.8 V</text> |
There was a problem hiding this comment.
Since we don't actually get a voltage value right now, it might be nice to have an icon or graphic here instead
| <text id="voltage">14.8 V</text> | ||
| <text id="hull-status">Battery Low.</text> | ||
| <text id="btstatus">OK</text> | ||
| <text id="trimtab-voltage">5.0 V</text> |
There was a problem hiding this comment.
We don't actually get a voltage from the trim tab controller. We get a percentage.
There was a problem hiding this comment.
Changing representation to a % symbol in the next commit
The dashboard WORKS for
---- MORE UPDATES TBD