Skip to content
This repository was archived by the owner on Sep 27, 2023. It is now read-only.

Jarius - telemetry update (4/5/2022) - #1

Open
jthomas845 wants to merge 5 commits into
masterfrom
jarius-fix-2020-errors
Open

Jarius - telemetry update (4/5/2022)#1
jthomas845 wants to merge 5 commits into
masterfrom
jarius-fix-2020-errors

Conversation

@jthomas845

Copy link
Copy Markdown

The dashboard WORKS for

  • magnetic heading (curr. heading)
  • Relative wind (apparent wind)
  • Pitch & roll

---- MORE UPDATES TBD

Jarius Thomas added 3 commits March 28, 2022 02:34
added new fields
Telemetry Works for updating the following:
- relative wind
- pitch and roll (updates very slowly)
- magnetic heading (current heading)

@tnurse18 tnurse18 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Overall just a few minor things here and there that caught my attention.

@@ -1,4 +1,11 @@
const socket = io(); // socket initialization
//const socket = io("http://localhost:3000/", { transports: ['polling', 'flashsocket'] }); // socket initialization

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep this. This way we won't need to manually change this IP address every time we use a different one.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be re-implemented using localhost

Comment thread public/index.html Outdated
<link rel="stylesheet" href="css/foundation.css">
<link rel="shortcut icon" href="/assets/favicon.ico" type="image/x-icon">
<link rel="icon" href="/assets/favicon.ico" type="image/x-icon">
<link rel="shortcut icon" href="../public/assets/favicon.ico" type="image/x-icon">

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a relative path you should be able to do the following where applicable:

Suggested change
<link rel="shortcut icon" href="../public/assets/favicon.ico" type="image/x-icon">
<link rel="shortcut icon" href="assets/favicon.ico" type="image/x-icon">

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using this in new commit

Comment thread public/index.html
<script type="text/javascript" src="/js/dependencies/d3.min.js" charset="utf-8"></script>
<script type="text/javascript" src="/js/dependencies/d3gauge.js" charset="utf-8"></script>
<script type="text/javascript" src="/js/dependencies/FileSaver.min.js" charset="utf-8"></script>
<script type="text/javascript" src="./js/dependencies/socket.io.min.js"></script>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<script type="text/javascript" src="./js/dependencies/socket.io.min.js"></script>
<script type="text/javascript" src="js/dependencies/socket.io.min.js"></script>

Comment thread public/index.html Outdated
<text>Trim Battery:</text>
</div>
<div class="values">
<text id="voltage">14.8 V</text>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we don't actually get a voltage value right now, it might be nice to have an icon or graphic here instead

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

graphic is set

Comment thread public/index.html Outdated
<text id="voltage">14.8 V</text>
<text id="hull-status">Battery Low.</text>
<text id="btstatus">OK</text>
<text id="trimtab-voltage">5.0 V</text>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't actually get a voltage from the trim tab controller. We get a percentage.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing representation to a % symbol in the next commit

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants