Skip to content

feat: Gas benchmark regression CI gate - #129

Open
raizo07 wants to merge 2 commits into
wraith-protocol:developfrom
raizo07:feat/Gas-benchmark
Open

feat: Gas benchmark regression CI gate#129
raizo07 wants to merge 2 commits into
wraith-protocol:developfrom
raizo07:feat/Gas-benchmark

Conversation

@raizo07

@raizo07 raizo07 commented Jul 24, 2026

Copy link
Copy Markdown

closes #112

@drips-wave

drips-wave Bot commented Jul 24, 2026

Copy link
Copy Markdown

@raizo07 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@truthixify

Copy link
Copy Markdown
Contributor

The stellar and stellar-bench-pr checks failed against an older workspace state that has since been fixed on develop. Rebase and force-push and CI should look different.

@truthixify

Copy link
Copy Markdown
Contributor

Rebase against develop, conflicts appeared after the recent contracts merge cascade. Force-push and CI will re-fire.

@truthixify

Copy link
Copy Markdown
Contributor

Two specific failures:

  1. stellar fails on cargo fmt --all --check — run cargo fmt --all in stellar/ and commit.

  2. stellar-bench-pr fails with error: unknown argument: --bench from your gas benchmark binary. Cargo passes --bench to the binary automatically after your other args (that's what the trailing --bench in the log means). Two options:

    • Make the gas binary silently accept/ignore an unknown --bench flag, OR
    • Switch the workflow invocation from cargo bench to cargo run --release --bin gas -- --format json --out bench/results.json (which won't append --bench).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gas benchmark regression CI gate

2 participants