Fix in KPP compilation during integration edit to use correct make variable #2222
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: make, compilation
SOURCE: internal
DESCRIPTION OF CHANGES:
Problem:
PR #2018 introduced CMake compilation of the chem and KPP code. In order to do that certain helper programs created during the compilation process were reworked. The KPP mechanism integration edit program,
integr_edit.exewas changed to take in explicit arguments for the files to read and write. However, the edits to the makefile that control this call use an invalid variable$(MODEL)where$(MECH)should be used instead.Solution:
Use the appropriate
$(MECH)variable to construct command line arguments tointergr_edit.exeISSUE:
#2216
TESTS CONDUCTED: