Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate IdentityKeyStoreResolver #160

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

Binara-Sachin
Copy link

Purpose

  • This PR integrates the IdentityKeyStoreResolver class into the WS-Federation and WS-Trust flows.
  • This will allow users to define custom key stores for each authentication flow.

Important


@CLAassistant
Copy link

CLAassistant commented Jul 25, 2024

CLA assistant check
All committers have signed the CLA.

@Binara-Sachin Binara-Sachin marked this pull request as ready for review July 30, 2024 04:39
@ZiyamSanthosh
Copy link

Unit tests have failed. Please check if it is due to these changes and address them.

<identity.framework.version>7.0.73</identity.framework.version>
<identity.framework.version>7.5.64</identity.framework.version>
<!-- TODO: Bump org.wso2.carbon.identity.testutil to same identity.framework.version-->
<identity.framework.testutil.version>7.0.73</identity.framework.testutil.version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we can't use the framework version itself

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous tests had failed due to the following change,

We may need to make significant changes to existing tests/dependencies in the repo to incorporate the changes properly.
IMO this should be done as a separate task.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That dependency issue is resolved by this PR, #165. So you should be able to use a single framework dependency.

@Binara-Sachin
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants