Integrate IdentityKeyStoreResolver #160
Open
+52
−98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ImalshaG
reviewed
Jul 31, 2024
...src/main/java/org/wso2/carbon/identity/sts/passive/custom/provider/CustomCryptoProvider.java
Outdated
Show resolved
Hide resolved
pamodaaw
reviewed
Oct 22, 2024
...src/main/java/org/wso2/carbon/identity/sts/passive/custom/provider/CustomCryptoProvider.java
Outdated
Show resolved
Hide resolved
pamodaaw
reviewed
Oct 22, 2024
...s.passive/src/main/java/org/wso2/carbon/identity/sts/passive/utils/RequestProcessorUtil.java
Outdated
Show resolved
Hide resolved
pamodaaw
reviewed
Oct 22, 2024
...s.passive/src/main/java/org/wso2/carbon/identity/sts/passive/utils/RequestProcessorUtil.java
Outdated
Show resolved
Hide resolved
|
Unit tests have failed. Please check if it is due to these changes and address them. |
pamodaaw
reviewed
Oct 23, 2024
| <identity.framework.version>7.0.73</identity.framework.version> | ||
| <identity.framework.version>7.5.64</identity.framework.version> | ||
| <!-- TODO: Bump org.wso2.carbon.identity.testutil to same identity.framework.version--> | ||
| <identity.framework.testutil.version>7.0.73</identity.framework.testutil.version> |
There was a problem hiding this comment.
Why we can't use the framework version itself
There was a problem hiding this comment.
Previous tests had failed due to the following change,
We may need to make significant changes to existing tests/dependencies in the repo to incorporate the changes properly.
IMO this should be done as a separate task.
There was a problem hiding this comment.
That dependency issue is resolved by this PR, #165. So you should be able to use a single framework dependency.
pamodaaw
reviewed
Oct 23, 2024
...src/main/java/org/wso2/carbon/identity/sts/passive/custom/provider/CustomCryptoProvider.java
Outdated
Show resolved
Hide resolved
pamodaaw
reviewed
Oct 23, 2024
...src/main/java/org/wso2/carbon/identity/sts/passive/custom/provider/CustomCryptoProvider.java
Outdated
Show resolved
Hide resolved
|
Created the doc PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
IdentityKeyStoreResolverclass into the WS-Federation and WS-Trust flows.Important