Skip to content

Restrict roles created in sub orgs to be associated with the non-shared apps in the sub organization #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ShanChathusanda93
Copy link
Contributor

@ShanChathusanda93 ShanChathusanda93 commented Jan 10, 2025

Changes in this PR

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 46.12%. Comparing base (ca48ef8) to head (3e1dfbf).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
.../identity/scim2/common/impl/SCIMRoleManagerV2.java 0.00% 17 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #593      +/-   ##
============================================
- Coverage     46.21%   46.12%   -0.09%     
+ Complexity     1126     1041      -85     
============================================
  Files            41       41              
  Lines          9125     9142      +17     
  Branches       2501     2505       +4     
============================================
  Hits           4217     4217              
- Misses         4057     4074      +17     
  Partials        851      851              
Flag Coverage Δ
unit 30.86% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ShanChathusanda93 ShanChathusanda93 changed the title Restrict roles created in sub orgs to be associated with the shared apps Restrict roles created in sub orgs to be associated with the non-shared apps in the sub organization Jan 27, 2025
@ShanChathusanda93 ShanChathusanda93 force-pushed the sub-org-role-shared-app-branch branch 3 times, most recently from 83f1e72 to 4af715f Compare February 13, 2025 08:41
SujanSanjula96
SujanSanjula96 previously approved these changes Feb 13, 2025
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/13304136646

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/13304136646
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/13304136646

@ShanChathusanda93
Copy link
Contributor Author

Integration test builder passed and the changes added lately are not tested from integration tests yet. Hence merging the PR.

cc @AnuradhaSK

@ShanChathusanda93 ShanChathusanda93 merged commit 7ca5a08 into wso2-extensions:master Feb 13, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants