-
Notifications
You must be signed in to change notification settings - Fork 156
Restrict roles created in sub orgs to be associated with the non-shared apps in the sub organization #593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict roles created in sub orgs to be associated with the non-shared apps in the sub organization #593
Conversation
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #593 +/- ##
============================================
- Coverage 46.21% 46.12% -0.09%
+ Complexity 1126 1041 -85
============================================
Files 41 41
Lines 9125 9142 +17
Branches 2501 2505 +4
============================================
Hits 4217 4217
- Misses 4057 4074 +17
Partials 851 851
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
...scim2.common/src/main/java/org/wso2/carbon/identity/scim2/common/impl/SCIMRoleManagerV2.java
Outdated
Show resolved
Hide resolved
83f1e72
to
4af715f
Compare
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/13304136646
...scim2.common/src/main/java/org/wso2/carbon/identity/scim2/common/impl/SCIMRoleManagerV2.java
Outdated
Show resolved
Hide resolved
...scim2.common/src/main/java/org/wso2/carbon/identity/scim2/common/impl/SCIMRoleManagerV2.java
Outdated
Show resolved
Hide resolved
...scim2.common/src/main/java/org/wso2/carbon/identity/scim2/common/impl/SCIMRoleManagerV2.java
Outdated
Show resolved
Hide resolved
…ed apps in the sub organization
4af715f
to
3e1dfbf
Compare
Integration test builder passed and the changes added lately are not tested from integration tests yet. Hence merging the PR. cc @AnuradhaSK |
7ca5a08
into
wso2-extensions:master
Changes in this PR