Add a secure random string generator for par URN generator #258
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a secure random string generator for par URN generator
This PR updates the random string generator from
RandomStringUtils.randomAlphanumeric(32)
toRandomStringUtils.random(32, 0, 0, true, true, null, new SecureRandom());
which is more secure than the first one.Using
RandomStringUtils.randomAlphanumeric(32)
from Apache Commons Lang is not considered secure for cryptographic purposes, as the underlying random number generator (java.util.Random
) is not cryptographically secure.This PR incorporates the
SecureRandom()
randomizer ofjava.security
package in order to make the random string generation secure and unpredictable.Issue link: #257
Doc Issue:
Applicable Labels: OB3 Accelerator
Development Checklist
Testing Checklist
Automation Test Details
Conformance Tests Details
Resources
Knowledge Base: https://sites.google.com/wso2.com/open-banking/
Guides: https://sites.google.com/wso2.com/open-banking/developer-guides