Generate jacoco report in conformance suite #21102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maduranga Siriwardena seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
madurangasiriwardena
force-pushed
the
master
branch
from
416591e
to
a4a9dc8
Compare
darshanasbg
reviewed
Sep 13, 2024
...jacoco-report-generator/src/main/java/org/wso2/carbon/identity/jacoco/CodeCoverageUtils.java
Outdated
Show resolved
Hide resolved
darshanasbg
reviewed
Sep 13, 2024
...jacoco-report-generator/src/main/java/org/wso2/carbon/identity/jacoco/CodeCoverageUtils.java
Outdated
Show resolved
Hide resolved
darshanasbg
reviewed
Sep 13, 2024
...jacoco-report-generator/src/main/java/org/wso2/carbon/identity/jacoco/CodeCoverageUtils.java
Outdated
Show resolved
Hide resolved
darshanasbg
reviewed
Sep 13, 2024
...jacoco-report-generator/src/main/java/org/wso2/carbon/identity/jacoco/CodeCoverageUtils.java
Outdated
Show resolved
Hide resolved
darshanasbg
reviewed
Sep 13, 2024
...n/jacoco-report-generator/src/main/java/org/wso2/carbon/identity/jacoco/ReportGenerator.java
Outdated
Show resolved
Hide resolved
madurangasiriwardena
force-pushed
the
master
branch
3 times, most recently
from
95172be
to
2f51345
Compare
darshanasbg
reviewed
Sep 13, 2024
...n/jacoco-report-generator/src/main/java/org/wso2/carbon/identity/jacoco/ReportGenerator.java
Outdated
Show resolved
Hide resolved
darshanasbg
reviewed
Sep 13, 2024
...n/jacoco-report-generator/src/main/java/org/wso2/carbon/identity/jacoco/ReportGenerator.java
Outdated
Show resolved
Hide resolved
darshanasbg
reviewed
Sep 13, 2024
...jacoco-report-generator/src/main/java/org/wso2/carbon/identity/jacoco/CodeCoverageUtils.java
Outdated
Show resolved
Hide resolved
darshanasbg
reviewed
Sep 13, 2024
...jacoco-report-generator/src/main/java/org/wso2/carbon/identity/jacoco/CodeCoverageUtils.java
Outdated
Show resolved
Hide resolved
darshanasbg
reviewed
Sep 13, 2024
...jacoco-report-generator/src/main/java/org/wso2/carbon/identity/jacoco/CodeCoverageUtils.java
Outdated
Show resolved
Hide resolved
madurangasiriwardena
force-pushed
the
master
branch
from
2f51345
to
5d53b85
Compare
madurangasiriwardena
force-pushed
the
master
branch
from
5d53b85
to
eca3a88
Compare
darshanasbg
reviewed
Sep 13, 2024
|
|
||
| for (File classDirectory : classDirectories) { | ||
| // Jar files to analyze | ||
| File[] files = classDirectory.listFiles((dir, name) -> name.startsWith("org.wso2.carbon") && !name.contains(".stub_")); |
There was a problem hiding this comment.
have we considered ignoring carbon ui components?
There was a problem hiding this comment.
We can ignore them during the report analysis level at the module repository level.
darshanasbg
reviewed
Sep 13, 2024
...jacoco-report-generator/src/main/java/org/wso2/carbon/identity/jacoco/CodeCoverageUtils.java
Outdated
Show resolved
Hide resolved
darshanasbg
reviewed
Sep 13, 2024
| */ | ||
| public void create() throws IOException { | ||
|
|
||
| // Read the jacoco.exec file. Multiple data files could be merged |
There was a problem hiding this comment.
These comments can be moved as method comments
There was a problem hiding this comment.
I think this is better suited to explain the method invocation. Improved the method comment with #21108
darshanasbg
reviewed
Sep 13, 2024
|
|
||
| private void createReport(final IBundleCoverage bundleCoverage) throws IOException { | ||
|
|
||
| // Create a concrete report visitor based on some supplied |
There was a problem hiding this comment.
Move as method comment?
There was a problem hiding this comment.
Done with #21108
darshanasbg
reviewed
Sep 13, 2024
| * @return - Jar file extracted directory. | ||
| * @throws IOException - Throws if jar extraction fails | ||
| */ | ||
| public synchronized static String extractJarFile(String jarFilePath, File tempDir) throws IOException { |
There was a problem hiding this comment.
Do we really need this to be synchronized here?
There was a problem hiding this comment.
Done with #21108
darshanasbg
approved these changes
Sep 13, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #21117