Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Choreo] Changes to consider organization with subscription policies #3504

Merged
merged 18 commits into from
May 8, 2024
Merged

[Choreo] Changes to consider organization with subscription policies #3504

merged 18 commits into from
May 8, 2024

Conversation

slahirucd7
Copy link
Contributor

@slahirucd7 slahirucd7 commented Apr 25, 2024 •
edited
Loading

Purpose

$subject
Relevant issue(s):
https://github.com/wso2-enterprise/choreo/issues/27601
https://github.com/wso2-enterprise/choreo/issues/29451

Issues

Fixes #

Automation tests

  • Unit tests added: Yes
  • Integration tests added: No

Tested environments

Not Tested

Maintainers: Check before merge

  • Assigned 'Type' label
  • Assigned the project
  • Validated respective github issues
  • Assigned milestone to the github issue(s)

@CLAassistant
Copy link

CLAassistant commented Apr 25, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@slahirucd7 slahirucd7 added Choreo go Pull requests that update Go code java Pull requests that update Java code Type/New Feature labels Apr 25, 2024
renuka-fernando
renuka-fernando reviewed May 4, 2024
View reviewed changes
adapter/internal/discovery/xds/rate_limiter_cache.go Outdated
Comment on lines 338 to 341
// Check if rlsPolicyCache.metadataBasedPolicies[Subscription] exists and create a new map if not
if _, ok := rlsPolicyCache.metadataBasedPolicies[subscriptionPolicyType]; !ok {
rlsPolicyCache.metadataBasedPolicies[subscriptionPolicyType] = make(map[string]map[string]*rls_config.RateLimitDescriptor)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to do this inside this for loop. We can keep it in the original location.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let move this to original place

@slahirucd7 slahirucd7 requested a review from renuka-fernando May 6, 2024 10:17
renuka-fernando
renuka-fernando previously approved these changes May 8, 2024
View reviewed changes
@renuka-fernando renuka-fernando merged commit 268c86a into wso2:choreo May 8, 2024
2 of 3 checks passed
@choreo-cicd
Copy link

[succeeded] Controlplane cluster : dev-deployment-v2 : 20240508.25

@choreo-cicd
Copy link

[succeeded] Dataplane(EastUS) cluster : dev-deployment-v2 : 20240508.25

@choreo-cicd
Copy link

[succeeded] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20240508.25

@choreo-cicd
Copy link

[succeeded] : dev-deployment-v2 : 20240508.25

@choreo-cicd
Copy link

[failed] Dataplane(EastUS) cluster : stage-deployment-v2 : 20240513.3

@choreo-cicd
Copy link

[failed] Controlplane cluster : stage-deployment-v2 : 20240513.3

@choreo-cicd
Copy link

[failed] Dataplane(NorthEU) cluster : stage-deployment-v2 : 20240513.4

@choreo-cicd
Copy link

[failed] Dataplane(CDP2-WU2) cluster : stage-deployment-v2 : 20240513.4

@choreo-cicd
Copy link

[failed] Dataplane(EastUS) cluster : stage-deployment-v2 : 20240513.4

@choreo-cicd
Copy link

[failed] Dataplane(CDP2-WU2) cluster : stage-deployment-v2 : 20240513.5

@choreo-cicd
Copy link

[failed] Dataplane(EastUS) cluster : stage-deployment-v2 : 20240513.5

@choreo-cicd
Copy link

[] Dataplane(NorthEU) cluster : stage-deployment-v2 : 20240513.6

@choreo-cicd
Copy link

[] Controlplane cluster : stage-deployment-v2 : 20240513.6

@choreo-cicd
Copy link

[] Dataplane(CDP2-WU2) cluster : prod-deployment-v2 : 20240515.2

1 similar comment
@choreo-cicd
Copy link

[] Dataplane(CDP2-WU2) cluster : prod-deployment-v2 : 20240515.2

@choreo-cicd
Copy link

[] Dataplane(EastUS) cluster : prod-deployment-v2 : 20240515.2

1 similar comment
@choreo-cicd
Copy link

[] Dataplane(EastUS) cluster : prod-deployment-v2 : 20240515.2

@choreo-cicd
Copy link

[] Controlplane cluster : prod-deployment-v2 : 20240515.2

1 similar comment
@choreo-cicd
Copy link

[] Controlplane cluster : prod-deployment-v2 : 20240515.2

@choreo-cicd
Copy link

[] Dataplane(NorthEU) cluster : prod-deployment-v2 : 20240515.2

1 similar comment
@choreo-cicd
Copy link

[] Dataplane(NorthEU) cluster : prod-deployment-v2 : 20240515.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renuka-fernando renuka-fernando renuka-fernando approved these changes

@malinthaprasan malinthaprasan Awaiting requested review from malinthaprasan

@VirajSalaka VirajSalaka Awaiting requested review from VirajSalaka

Assignees
No one assigned
Labels
Choreo go Pull requests that update Go code java Pull requests that update Java code Status/DeployedToDev Status/DeployedToProd Status/DeployedToStage Type/New Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@slahirucd7 @CLAassistant @choreo-cicd @VirajSalaka @renuka-fernando