Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Choreo] Fix intelligent routing availability after deleting and re-creating an API #3506

Merged
merged 3 commits into from
May 10, 2024
Merged

[Choreo] Fix intelligent routing availability after deleting and re-creating an API #3506

merged 3 commits into from
May 10, 2024

Conversation

chathuranga95
Copy link

@chathuranga95 chathuranga95 commented May 8, 2024 •
edited
Loading

Purpose

This PR,

  • Removes unwanted minor version based intelligent routing regex building for the envoy router
  • Fixes a bug where the vhost is neglected on API undeployment

Issues

Addresses: https://github.com/wso2-enterprise/choreo/issues/28419

Automation tests

  • Unit tests added: No
  • Integration tests added: No

Tested environments

OS: ubuntu
Go: 1.22

Maintainers: Check before merge

  • Assigned 'Type' label
  • Assigned the project
  • Validated respective github issues
  • Assigned milestone to the github issue(s)

@chathuranga95 chathuranga95 changed the title Fix intelligent routing availability after deleting and re-creating an API [Choreo] Fix intelligent routing availability after deleting and re-creating an API May 9, 2024
VirajSalaka
VirajSalaka previously approved these changes May 10, 2024
View reviewed changes
VirajSalaka
VirajSalaka reviewed May 10, 2024
View reviewed changes
adapter/internal/discovery/xds/semantic_versioning.go
@@ -36,34 +36,14 @@ func GetVersionMatchRegex(version string) string {
func GetMajorMinorVersionRangeRegex(semVersion semantic_version.SemVersion) string {
majorVersion := strconv.Itoa(semVersion.Major)
minorVersion := strconv.Itoa(semVersion.Minor)
if semVersion.Patch == nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we remove Patch property from the struct as well.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done with: f7728c1

@chathuranga95 chathuranga95 merged commit ccc690e into wso2:choreo May 10, 2024
2 of 3 checks passed
@choreo-cicd
Copy link

[succeeded] : dev-deployment-v2 : 20240510.15

@choreo-cicd
Copy link

[succeeded] Controlplane cluster : dev-deployment-v2 : 20240510.15

@choreo-cicd
Copy link

[succeeded] Dataplane(EastUS) cluster : dev-deployment-v2 : 20240510.15

@choreo-cicd
Copy link

[succeeded] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20240510.15

@choreo-cicd
Copy link

[failed] Dataplane(EastUS) cluster : stage-deployment-v2 : 20240513.3

@choreo-cicd
Copy link

[failed] Controlplane cluster : stage-deployment-v2 : 20240513.3

@choreo-cicd
Copy link

[failed] Dataplane(NorthEU) cluster : stage-deployment-v2 : 20240513.4

@choreo-cicd
Copy link

[failed] Dataplane(CDP2-WU2) cluster : stage-deployment-v2 : 20240513.4

@choreo-cicd
Copy link

[failed] Dataplane(EastUS) cluster : stage-deployment-v2 : 20240513.4

@choreo-cicd
Copy link

[failed] Dataplane(CDP2-WU2) cluster : stage-deployment-v2 : 20240513.5

@choreo-cicd
Copy link

[failed] Dataplane(EastUS) cluster : stage-deployment-v2 : 20240513.5

@choreo-cicd
Copy link

[] Dataplane(NorthEU) cluster : stage-deployment-v2 : 20240513.6

@choreo-cicd
Copy link

[] Controlplane cluster : stage-deployment-v2 : 20240513.6

@chathuranga95 chathuranga95 mentioned this pull request May 13, 2024
Merged
@choreo-cicd
Copy link

[] Dataplane(CDP2-WU2) cluster : prod-deployment-v2 : 20240515.2

1 similar comment
@choreo-cicd
Copy link

[] Dataplane(CDP2-WU2) cluster : prod-deployment-v2 : 20240515.2

@choreo-cicd
Copy link

[] Dataplane(EastUS) cluster : prod-deployment-v2 : 20240515.2

1 similar comment
@choreo-cicd
Copy link

[] Dataplane(EastUS) cluster : prod-deployment-v2 : 20240515.2

@choreo-cicd
Copy link

[] Controlplane cluster : prod-deployment-v2 : 20240515.2

@choreo-cicd
Copy link

[] Controlplane cluster : prod-deployment-v2 : 20240515.2

@choreo-cicd
Copy link

[] Dataplane(NorthEU) cluster : prod-deployment-v2 : 20240515.2

1 similar comment
@choreo-cicd
Copy link

[] Dataplane(NorthEU) cluster : prod-deployment-v2 : 20240515.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VirajSalaka VirajSalaka VirajSalaka approved these changes

Assignees
No one assigned
Labels
Status/DeployedToDev Status/DeployedToProd Status/DeployedToStage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chathuranga95 @choreo-cicd @VirajSalaka