Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for invocations with internal key for Websocket APIs #3514

Merged
merged 5 commits into from
May 14, 2024
Merged

Add support for invocations with internal key for Websocket APIs #3514

merged 5 commits into from
May 14, 2024

Conversation

Thushani-Jayasekera
Copy link

@Thushani-Jayasekera Thushani-Jayasekera commented May 13, 2024 •
edited
Loading

Purpose

At invocation, we get the below error log in enforcer. This PR will fix it.
Additionally it fixes the issue of being unable to invoke sandbox deployment using the sandbox internal api key

13/05/2024, 22:01:17.851
choreo-connect-deployment-external-p3-68fb7b84f4
at org.wso2.choreo.connect.enforcer.grpc.ExtAuthService.check(ExtAuthService.java:83)
13/05/2024, 22:01:17.851
choreo-connect-deployment-external-p3-68fb7b84f4
at org.wso2.choreo.connect.enforcer.grpc.ExtAuthService.buildResponse(ExtAuthService.java:193)

https://github.com/wso2-enterprise/choreo/issues/26743

Issues

Fixes #

Automation tests

  • Unit tests added: Yes
  • Integration tests added: Yes

Tested environments

Not Tested

Maintainers: Check before merge

  • Assigned 'Type' label
  • Assigned the project
  • Validated respective github issues
  • Assigned milestone to the github issue(s)

@Thushani-Jayasekera Thushani-Jayasekera requested review from VirajSalaka and removed request for VirajSalaka May 13, 2024 10:16
@Thushani-Jayasekera Thushani-Jayasekera changed the title Add support invoking with internal key for Websocket APIs Add support for invocations with internal key for Websocket APIs May 13, 2024
@malinthaprasan
Copy link

LGTM

@malinthaprasan malinthaprasan merged commit 5ec1d7b into wso2:choreo May 14, 2024
2 of 3 checks passed
@choreo-cicd
Copy link

[succeeded] Controlplane cluster : dev-deployment-v2 : 20240514.24

@choreo-cicd
Copy link

[succeeded] Dataplane(EastUS) cluster : dev-deployment-v2 : 20240514.24

@choreo-cicd
Copy link

[succeeded] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20240514.24

@choreo-cicd
Copy link

[succeeded] : dev-deployment-v2 : 20240514.24

@choreo-cicd
Copy link

[failed] Dataplane(NorthEU) cluster : stage-deployment-v2 : 20240516.1

@choreo-cicd
Copy link

[failed] Dataplane(EastUS) cluster : stage-deployment-v2 : 20240516.1

@choreo-cicd
Copy link

[failed] Controlplane cluster : stage-deployment-v2 : 20240516.1

@choreo-cicd
Copy link

[failed] Dataplane(NorthEU) cluster : stage-deployment-v2 : 20240516.1

@choreo-cicd
Copy link

[failed] Dataplane(EastUS) cluster : stage-deployment-v2 : 20240516.1

@choreo-cicd
Copy link

[succeeded] Controlplane cluster : stage-deployment-v2 : 20240516.1

@choreo-cicd
Copy link

[succeeded] Dataplane(EastUS) cluster : stage-deployment-v2 : 20240516.1

@choreo-cicd
Copy link

[succeeded] Controlplane cluster : stage-deployment-v2 : 20240516.1

@choreo-cicd
Copy link

[succeeded] Dataplane(NorthEU) cluster : stage-deployment-v2 : 20240516.1

@choreo-cicd
Copy link

[] Dataplane(CDP2-WU2) cluster : stage-deployment-v2 : 20240516.2

1 similar comment
@choreo-cicd
Copy link

[] Dataplane(CDP2-WU2) cluster : stage-deployment-v2 : 20240516.2

@choreo-cicd
Copy link

[] Controlplane cluster : stage-deployment-v2 : 20240516.2

@choreo-cicd
Copy link

[succeeded] Controlplane cluster : prod-deployment-v2 : 20240517.2

1 similar comment
@choreo-cicd
Copy link

[succeeded] Controlplane cluster : prod-deployment-v2 : 20240517.2

@choreo-cicd
Copy link

[canceled] Dataplane(EastUS) cluster : prod-deployment-v2 : 20240517.2

1 similar comment
@choreo-cicd
Copy link

[canceled] Dataplane(EastUS) cluster : prod-deployment-v2 : 20240517.2

@choreo-cicd
Copy link

[] Dataplane(NorthEU) cluster : prod-deployment-v2 : 20240517.3

1 similar comment
@choreo-cicd
Copy link

[] Dataplane(NorthEU) cluster : prod-deployment-v2 : 20240517.3

@choreo-cicd
Copy link

[] Dataplane(CDP2-WU2) cluster : prod-deployment-v2 : 20240517.3

1 similar comment
@choreo-cicd
Copy link

[] Dataplane(CDP2-WU2) cluster : prod-deployment-v2 : 20240517.3

@choreo-cicd
Copy link

[] Controlplane cluster : prod-deployment-v2 : 20240517.3

1 similar comment
@choreo-cicd
Copy link

[] Controlplane cluster : prod-deployment-v2 : 20240517.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renuka-fernando renuka-fernando renuka-fernando approved these changes

@VirajSalaka VirajSalaka Awaiting requested review from VirajSalaka

Assignees
No one assigned
Labels
Status/DeployedToDev Status/DeployedToProd Status/DeployedToStage Type/Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Thushani-Jayasekera @malinthaprasan @choreo-cicd @renuka-fernando