Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Choreo] Fix intelligent routing availability after deleting and re-creating an API #3518

Merged

Conversation

chathuranga95
Copy link

Purpose

This PR,

  • Removes unwanted minor version based intelligent routing regex building for the envoy router
  • Fixes a bug where the vhost is neglected on API undeployment

Issues

Addresses: https://github.com/wso2-enterprise/choreo/issues/28419

Automation tests

  • Unit tests added: No
  • Integration tests added: No

Tested environments

OS: Mac 14.3
Go: 1.22.1
Java: 11.0.19


Maintainers: Check before merge

  • Assigned 'Type' label
  • Assigned the project
  • Validated respective github issues
  • Assigned milestone to the github issue(s)

@chathuranga95 chathuranga95 requested a review from VirajSalaka May 14, 2024 10:25
@chathuranga95 chathuranga95 merged commit aa68bcf into wso2:choreo May 14, 2024
1 of 2 checks passed
@choreo-cicd
Copy link

[succeeded] Controlplane cluster : dev-deployment-v2 : 20240514.28

@choreo-cicd
Copy link

[succeeded] Dataplane(EastUS) cluster : dev-deployment-v2 : 20240514.28

@choreo-cicd
Copy link

[succeeded] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20240514.28

@choreo-cicd
Copy link

[succeeded] : dev-deployment-v2 : 20240514.28

@choreo-cicd
Copy link

[failed] Dataplane(NorthEU) cluster : stage-deployment-v2 : 20240516.1

@choreo-cicd
Copy link

[failed] Dataplane(EastUS) cluster : stage-deployment-v2 : 20240516.1

@choreo-cicd
Copy link

[failed] Controlplane cluster : stage-deployment-v2 : 20240516.1

@choreo-cicd
Copy link

[failed] Dataplane(NorthEU) cluster : stage-deployment-v2 : 20240516.1

@choreo-cicd
Copy link

[failed] Dataplane(EastUS) cluster : stage-deployment-v2 : 20240516.1

@choreo-cicd
Copy link

[succeeded] Controlplane cluster : stage-deployment-v2 : 20240516.1

@choreo-cicd
Copy link

[succeeded] Dataplane(EastUS) cluster : stage-deployment-v2 : 20240516.1

@choreo-cicd
Copy link

[succeeded] Controlplane cluster : stage-deployment-v2 : 20240516.1

@choreo-cicd
Copy link

[succeeded] Dataplane(NorthEU) cluster : stage-deployment-v2 : 20240516.1

@choreo-cicd
Copy link

[] Dataplane(CDP2-WU2) cluster : stage-deployment-v2 : 20240516.2

1 similar comment
@choreo-cicd
Copy link

[] Dataplane(CDP2-WU2) cluster : stage-deployment-v2 : 20240516.2

@choreo-cicd
Copy link

[] Controlplane cluster : stage-deployment-v2 : 20240516.2

@choreo-cicd
Copy link

[succeeded] Controlplane cluster : prod-deployment-v2 : 20240517.2

1 similar comment
@choreo-cicd
Copy link

[succeeded] Controlplane cluster : prod-deployment-v2 : 20240517.2

@choreo-cicd
Copy link

[canceled] Dataplane(EastUS) cluster : prod-deployment-v2 : 20240517.2

1 similar comment
@choreo-cicd
Copy link

[canceled] Dataplane(EastUS) cluster : prod-deployment-v2 : 20240517.2

@choreo-cicd
Copy link

[] Dataplane(NorthEU) cluster : prod-deployment-v2 : 20240517.3

1 similar comment
@choreo-cicd
Copy link

[] Dataplane(NorthEU) cluster : prod-deployment-v2 : 20240517.3

@choreo-cicd
Copy link

[] Dataplane(CDP2-WU2) cluster : prod-deployment-v2 : 20240517.3

@choreo-cicd
Copy link

[] Dataplane(CDP2-WU2) cluster : prod-deployment-v2 : 20240517.3

@choreo-cicd
Copy link

[] Controlplane cluster : prod-deployment-v2 : 20240517.3

1 similar comment
@choreo-cicd
Copy link

[] Controlplane cluster : prod-deployment-v2 : 20240517.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants