[Choreo] Implementations for burst controlling support with subscription policies #3523

slahirucd7 · 2024-05-21T04:13:44Z

Purpose

$subject
Related issue: https://github.com/wso2-enterprise/choreo/issues/28599

Issues

Fixes #

Automation tests

Unit tests added: No
Integration tests added: No

Tested environments

Not Tested

Maintainers: Check before merge

Assigned 'Type' label
Assigned the project
Validated respective github issues
Assigned milestone to the github issue(s)

adapter/internal/discovery/xds/rate_limiter_cache.go

renuka-fernando · 2024-05-26T16:17:46Z

adapter/internal/messaging/notification_listener.go

-			Name: subscriptionPolicyEvent.PolicyName, QuotaType: subscriptionPolicyEvent.QuotaType,
+		subscriptionPolicy := types.SubscriptionPolicy{
+			ID:                   subscriptionPolicyEvent.PolicyID,
+			TenantID:             TenantID,


We can remove TenantID from CC. Are we processing it?
@malinthaprasan wdyt?

TenantId will always be -1234 (super tenant) in Choreo. In some cases I have seen it's 0 in some variables when it's not set properly. Anyway there's no use case to process the tenant ID in Choreo. If we can remove it without breaking the code, +1 to do it.

Check how tenant ID parsed in other event types ?

Checked during the PR review.

adapter/internal/oasparser/envoyconf/routes_with_clusters.go

...t/enforcer/src/main/java/org/wso2/choreo/connect/enforcer/security/jwt/JWTAuthenticator.java

adapter/internal/discovery/xds/rate_limiter_cache.go

malinthaprasan · 2024-05-27T02:31:31Z

@renuka-fernando @slahirucd7
Shall we have a quick review for this via a call? Just wanted to understand how the data structures are kept etc.

...arent/enforcer/src/main/java/org/wso2/choreo/connect/enforcer/models/SubscriptionPolicy.java

...r/src/main/java/org/wso2/choreo/connect/enforcer/subscription/SubscriptionDataStoreImpl.java

adapter/internal/discovery/xds/rate_limiter_cache.go

minor improvements changes for review suggestions changes for review suggestions

adapter/internal/discovery/xds/marshaller.go

adapter/internal/discovery/xds/rate_limiter_cache_test.go

minor correction

choreo-cicd · 2024-05-29T16:47:31Z

[succeeded] Dataplane(EastUS) cluster : dev-deployment-v2 : 20240529.22

choreo-cicd · 2024-05-29T16:47:32Z

[succeeded] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20240529.22

choreo-cicd · 2024-05-29T16:47:32Z

[succeeded] : dev-deployment-v2 : 20240529.22

choreo-cicd · 2024-05-29T16:47:33Z

[succeeded] Controlplane cluster : dev-deployment-v2 : 20240529.22

choreo-cicd · 2024-05-30T04:33:35Z

[failed] Dataplane(EastUS) cluster : stage-deployment-v2 : 20240530.3

choreo-cicd · 2024-05-30T04:33:35Z

[failed] Controlplane cluster : stage-deployment-v2 : 20240530.3

choreo-cicd · 2024-05-30T04:33:37Z

[succeeded] Dataplane(NorthEU) cluster : stage-deployment-v2 : 20240530.3

choreo-cicd · 2024-05-30T04:33:37Z

[succeeded] Dataplane(CDP2-WU2) cluster : stage-deployment-v2 : 20240530.3

choreo-cicd · 2024-05-30T05:05:32Z

[succeeded] Dataplane(EastUS) cluster : stage-deployment-v2 : 20240530.4

choreo-cicd · 2024-05-30T05:35:55Z

[] Controlplane cluster : stage-deployment-v2 : 20240530.6

choreo-cicd · 2024-05-30T05:36:06Z

[] Dataplane(EastUS) cluster : stage-deployment-v2 : 20240530.6

choreo-cicd · 2024-05-30T05:36:07Z

[] Dataplane(NorthEU) cluster : stage-deployment-v2 : 20240530.6

choreo-cicd · 2024-05-30T05:36:07Z

[] Dataplane(CDP2-WU2) cluster : stage-deployment-v2 : 20240530.6

choreo-cicd · 2024-05-31T07:05:15Z

[failed] Controlplane cluster : prod-deployment-v2 : 20240531.3

choreo-cicd · 2024-05-31T07:05:28Z

[succeeded] Dataplane(NorthEU) cluster : prod-deployment-v2 : 20240531.3

choreo-cicd · 2024-05-31T07:05:30Z

[succeeded] Dataplane(CDP2-WU2) cluster : prod-deployment-v2 : 20240531.3

choreo-cicd · 2024-05-31T07:05:32Z

[succeeded] Dataplane(EastUS) cluster : prod-deployment-v2 : 20240531.3

choreo-cicd · 2024-05-31T07:15:22Z

[] Dataplane(CDP2-WU2) cluster : prod-deployment-v2 : 20240531.4

choreo-cicd · 2024-05-31T07:15:24Z

[] Dataplane(EastUS) cluster : prod-deployment-v2 : 20240531.4

choreo-cicd · 2024-05-31T07:15:25Z

[] Controlplane cluster : prod-deployment-v2 : 20240531.4

choreo-cicd · 2024-05-31T07:15:38Z

[] Dataplane(NorthEU) cluster : prod-deployment-v2 : 20240531.4

choreo-cicd · 2024-05-31T09:06:10Z

[succeeded] Dataplane(CDP2-WU2) cluster : prod-deployment-v2 : 20240531.3

choreo-cicd · 2024-05-31T09:06:13Z

[succeeded] Controlplane cluster : prod-deployment-v2 : 20240531.3

choreo-cicd · 2024-05-31T09:06:31Z

[succeeded] Dataplane(EastUS) cluster : prod-deployment-v2 : 20240531.3

choreo-cicd · 2024-05-31T09:06:35Z

[succeeded] Dataplane(NorthEU) cluster : prod-deployment-v2 : 20240531.3

implementations for burst controlling support with subscription policies

8eacf5a

slahirucd7 added Type/Task Choreo java Pull requests that update Java code go Pull requests that update Go code labels May 21, 2024

slahirucd7 commented May 21, 2024

View reviewed changes

adapter/internal/discovery/xds/rate_limiter_cache.go Outdated Show resolved Hide resolved

renuka-fernando reviewed May 26, 2024

View reviewed changes

adapter/internal/discovery/xds/rate_limiter_cache.go Show resolved Hide resolved

renuka-fernando requested a review from malinthaprasan May 26, 2024 16:39

renuka-fernando reviewed May 26, 2024

View reviewed changes

slahirucd7 commented May 27, 2024

View reviewed changes

...arent/enforcer/src/main/java/org/wso2/choreo/connect/enforcer/models/SubscriptionPolicy.java Outdated Show resolved Hide resolved

slahirucd7 commented May 27, 2024

View reviewed changes

...arent/enforcer/src/main/java/org/wso2/choreo/connect/enforcer/models/SubscriptionPolicy.java Outdated Show resolved Hide resolved

slahirucd7 commented May 27, 2024

View reviewed changes

...r/src/main/java/org/wso2/choreo/connect/enforcer/subscription/SubscriptionDataStoreImpl.java Outdated Show resolved Hide resolved

fix for test case failures

ad85f5e

malinthaprasan requested a review from VirajSalaka May 28, 2024 08:29

changes for review suggestions

30f5f35

slahirucd7 requested a review from renuka-fernando May 29, 2024 03:33

VirajSalaka reviewed May 29, 2024

View reviewed changes

adapter/internal/discovery/xds/rate_limiter_cache.go Outdated Show resolved Hide resolved

slahirucd7 force-pushed the choreo branch from 1bb93a4 to 22ef84e Compare May 29, 2024 06:07

minor improvements

89f048c

minor improvements changes for review suggestions changes for review suggestions

slahirucd7 force-pushed the choreo branch from 22ef84e to 89f048c Compare May 29, 2024 06:10

renuka-fernando reviewed May 29, 2024

View reviewed changes

adapter/internal/discovery/xds/marshaller.go Show resolved Hide resolved

renuka-fernando reviewed May 29, 2024

View reviewed changes

adapter/internal/discovery/xds/rate_limiter_cache_test.go Show resolved Hide resolved

changes for review suggestions

7d233ce

minor correction

slahirucd7 force-pushed the choreo branch from 1df0497 to 7d233ce Compare May 29, 2024 12:33

renuka-fernando approved these changes May 29, 2024

View reviewed changes

slahirucd7 merged commit 7b16481 into wso2:choreo May 29, 2024
3 checks passed

choreo-cicd added the Status/DeployedToDev label May 29, 2024

choreo-cicd added the Status/DeployedToStage label May 30, 2024

choreo-cicd added the Status/DeployedToProd label May 31, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Choreo] Implementations for burst controlling support with subscription policies #3523

[Choreo] Implementations for burst controlling support with subscription policies #3523

slahirucd7 commented May 21, 2024 •

edited

Loading

renuka-fernando May 26, 2024

malinthaprasan May 27, 2024

slahirucd7 May 27, 2024

slahirucd7 May 28, 2024

malinthaprasan commented May 27, 2024

choreo-cicd commented May 29, 2024

choreo-cicd commented May 29, 2024

choreo-cicd commented May 29, 2024

choreo-cicd commented May 29, 2024

choreo-cicd commented May 30, 2024

choreo-cicd commented May 30, 2024

choreo-cicd commented May 30, 2024

choreo-cicd commented May 30, 2024

choreo-cicd commented May 30, 2024

choreo-cicd commented May 30, 2024

choreo-cicd commented May 30, 2024

choreo-cicd commented May 30, 2024

choreo-cicd commented May 30, 2024

choreo-cicd commented May 31, 2024

choreo-cicd commented May 31, 2024

choreo-cicd commented May 31, 2024

choreo-cicd commented May 31, 2024

choreo-cicd commented May 31, 2024

choreo-cicd commented May 31, 2024

choreo-cicd commented May 31, 2024

choreo-cicd commented May 31, 2024

choreo-cicd commented May 31, 2024

choreo-cicd commented May 31, 2024

choreo-cicd commented May 31, 2024

choreo-cicd commented May 31, 2024

[Choreo] Implementations for burst controlling support with subscription policies #3523

[Choreo] Implementations for burst controlling support with subscription policies #3523

Conversation

slahirucd7 commented May 21, 2024 • edited Loading

Purpose

Issues

Automation tests

Tested environments

Maintainers: Check before merge

renuka-fernando May 26, 2024

Choose a reason for hiding this comment

malinthaprasan May 27, 2024

Choose a reason for hiding this comment

slahirucd7 May 27, 2024

Choose a reason for hiding this comment

slahirucd7 May 28, 2024

Choose a reason for hiding this comment

malinthaprasan commented May 27, 2024

choreo-cicd commented May 29, 2024

choreo-cicd commented May 29, 2024

choreo-cicd commented May 29, 2024

choreo-cicd commented May 29, 2024

choreo-cicd commented May 30, 2024

choreo-cicd commented May 30, 2024

choreo-cicd commented May 30, 2024

choreo-cicd commented May 30, 2024

choreo-cicd commented May 30, 2024

choreo-cicd commented May 30, 2024

choreo-cicd commented May 30, 2024

choreo-cicd commented May 30, 2024

choreo-cicd commented May 30, 2024

choreo-cicd commented May 31, 2024

choreo-cicd commented May 31, 2024

choreo-cicd commented May 31, 2024

choreo-cicd commented May 31, 2024

choreo-cicd commented May 31, 2024

choreo-cicd commented May 31, 2024

choreo-cicd commented May 31, 2024

choreo-cicd commented May 31, 2024

choreo-cicd commented May 31, 2024

choreo-cicd commented May 31, 2024

choreo-cicd commented May 31, 2024

choreo-cicd commented May 31, 2024

slahirucd7 commented May 21, 2024 •

edited

Loading