Skip to content

Add envoy config route validations for emoticons and substrings#3561

Merged
Drifftr merged 2 commits intowso2:choreofrom
Drifftr:choreo-validation
Aug 5, 2024
Merged

Add envoy config route validations for emoticons and substrings#3561
Drifftr merged 2 commits intowso2:choreofrom
Drifftr:choreo-validation

Conversation

@Drifftr
Copy link
Copy Markdown

@Drifftr Drifftr commented Aug 1, 2024 •
edited
Loading

Purpose

Add further validations for emoticons and substrings

Issues

https://github.com/wso2-enterprise/choreo/issues/28819

Automation tests

  • Unit tests added: Yes/No
  • Integration tests added: Yes/No

Tested environments

Not Tested

Maintainers: Check before merge

  • Assigned 'Type' label
  • Assigned the project
  • Validated respective github issues
  • Assigned milestone to the github issue(s)

@Drifftr Drifftr modified the milestone: 1.3.0-m1 Aug 1, 2024
@Drifftr Drifftr force-pushed the choreo-validation branch from 7132166 to 958ad1b Compare August 2, 2024 03:09
VirajSalaka
VirajSalaka reviewed Aug 2, 2024
View reviewed changes
Comment thread adapter/internal/oasparser/envoyconf/routes_with_clusters.go
}

// Validate envoy route method whether its of known type
func validateEnvoyRouteMethodString(method string) error {
Copy link
Copy Markdown
Contributor

@VirajSalaka VirajSalaka Aug 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From enforcer what we support is anyway "GET", "POST", "PUT", "DELETE", "PATCH", "HEAD", "OPTIONS".
Shall we remove the rest

Copy link
Copy Markdown
Author

@Drifftr Drifftr Aug 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Fixed.

@Drifftr Drifftr requested a review from VirajSalaka August 4, 2024 16:01
@Drifftr Drifftr merged commit f2b2296 into wso2:choreo Aug 5, 2024
@choreo-cicd
Copy link
Copy Markdown

choreo-cicd commented Aug 13, 2024

[succeeded] Dataplane(EastUS) cluster : dev-deployment-v2 : 20240813.19

@choreo-cicd
Copy link
Copy Markdown

choreo-cicd commented Aug 13, 2024

[succeeded] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20240813.19

@choreo-cicd
Copy link
Copy Markdown

choreo-cicd commented Aug 13, 2024

[succeeded] : dev-deployment-v2 : 20240813.19

@choreo-cicd
Copy link
Copy Markdown

choreo-cicd commented Aug 15, 2024

[succeeded] Controlplane cluster : stage-deployment-v2 : 20240815.3

@choreo-cicd
Copy link
Copy Markdown

choreo-cicd commented Aug 15, 2024

[failed] Dataplane(NorthEU) cluster : stage-deployment-v2 : 20240815.3

@choreo-cicd
Copy link
Copy Markdown

choreo-cicd commented Aug 15, 2024

[succeeded] Dataplane(CDP2-WU2) cluster : stage-deployment-v2 : 20240815.3

@choreo-cicd
Copy link
Copy Markdown

choreo-cicd commented Aug 15, 2024

[succeeded] Dataplane(EastUS) cluster : stage-deployment-v2 : 20240815.3

@choreo-cicd
Copy link
Copy Markdown

choreo-cicd commented Aug 15, 2024

[failed] Dataplane(NorthEU) cluster : stage-deployment-v2 : 20240815.4

@choreo-cicd
Copy link
Copy Markdown

choreo-cicd commented Aug 15, 2024

[succeeded] Controlplane cluster : stage-deployment-v2 : 20240815.3

@choreo-cicd
Copy link
Copy Markdown

choreo-cicd commented Aug 15, 2024

[failed] Dataplane(NorthEU) cluster : stage-deployment-v2 : 20240815.3

@choreo-cicd
Copy link
Copy Markdown

choreo-cicd commented Aug 15, 2024

[succeeded] Dataplane(CDP2-WU2) cluster : stage-deployment-v2 : 20240815.3

@choreo-cicd
Copy link
Copy Markdown

choreo-cicd commented Aug 15, 2024

[failed] Dataplane(NorthEU) cluster : stage-deployment-v2 : 20240815.3

@choreo-cicd
Copy link
Copy Markdown

choreo-cicd commented Aug 15, 2024

[succeeded] Dataplane(CDP2-WU2) cluster : stage-deployment-v2 : 20240815.3

@choreo-cicd
Copy link
Copy Markdown

choreo-cicd commented Aug 15, 2024

[succeeded] Dataplane(EastUS) cluster : stage-deployment-v2 : 20240815.3

@choreo-cicd
Copy link
Copy Markdown

choreo-cicd commented Aug 15, 2024

[succeeded] Controlplane cluster : stage-deployment-v2 : 20240815.3

@choreo-cicd
Copy link
Copy Markdown

choreo-cicd commented Aug 15, 2024

[] Controlplane cluster : stage-deployment-v2 : 20240815.5

@choreo-cicd
Copy link
Copy Markdown

choreo-cicd commented Aug 15, 2024

[] Dataplane(NorthEU) cluster : stage-deployment-v2 : 20240815.5

@choreo-cicd
Copy link
Copy Markdown

choreo-cicd commented Aug 15, 2024

[] Dataplane(CDP2-WU2) cluster : stage-deployment-v2 : 20240815.5

@choreo-cicd
Copy link
Copy Markdown

choreo-cicd commented Aug 15, 2024

[] Dataplane(EastUS) cluster : stage-deployment-v2 : 20240815.5

@choreo-cicd
Copy link
Copy Markdown

choreo-cicd commented Aug 16, 2024

[succeeded] Controlplane cluster : stage-deployment-v2 : 20240816.4

@choreo-cicd
Copy link
Copy Markdown

choreo-cicd commented Aug 16, 2024

[succeeded] Dataplane(NorthEU) cluster : stage-deployment-v2 : 20240816.4

@choreo-cicd
Copy link
Copy Markdown

choreo-cicd commented Aug 16, 2024

[succeeded] Dataplane(CDP2-WU2) cluster : stage-deployment-v2 : 20240816.4

@choreo-cicd
Copy link
Copy Markdown

choreo-cicd commented Aug 20, 2024

[succeeded] Dataplane(NorthEU) cluster : prod-deployment-v2 : 20240820.3

@choreo-cicd
Copy link
Copy Markdown

choreo-cicd commented Aug 20, 2024

[succeeded] Dataplane(CDP2-WU2) cluster : prod-deployment-v2 : 20240820.3

@choreo-cicd
Copy link
Copy Markdown

choreo-cicd commented Aug 20, 2024

[succeeded] Dataplane(EastUS) cluster : prod-deployment-v2 : 20240820.3

@choreo-cicd
Copy link
Copy Markdown

choreo-cicd commented Aug 20, 2024

[succeeded] Controlplane cluster : prod-deployment-v2 : 20240820.3

@choreo-cicd
Copy link
Copy Markdown

choreo-cicd commented Aug 20, 2024

[] Dataplane(EastUS) cluster : prod-deployment-v2 : 20240820.4

@choreo-cicd
Copy link
Copy Markdown

choreo-cicd commented Aug 20, 2024

[] Controlplane cluster : prod-deployment-v2 : 20240820.4

@choreo-cicd
Copy link
Copy Markdown

choreo-cicd commented Aug 20, 2024

[] Dataplane(NorthEU) cluster : prod-deployment-v2 : 20240820.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VirajSalaka VirajSalaka VirajSalaka approved these changes

Assignees

No one assigned

Labels

Status/DeployedToDev Status/DeployedToProd Status/DeployedToStage Type/Improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Drifftr @choreo-cicd @VirajSalaka