Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Choreo] Support passing API-Key for WebSocket Requests using sec-websocket-protocol Header #3562

Merged
merged 11 commits into from
Aug 9, 2024
Merged

[Choreo] Support passing API-Key for WebSocket Requests using sec-websocket-protocol Header #3562

merged 11 commits into from
Aug 9, 2024

Conversation

Thushani-Jayasekera
Copy link

@Thushani-Jayasekera Thushani-Jayasekera commented Aug 1, 2024 •
edited
Loading

Purpose

https://http.dev/ws#:~:text=The%20Sec%2DWebSocket%2DProtocol%20header,in%20a%20comma%2Ddelimited%20format.
https://github.com/wso2-enterprise/choreo/issues/26321

Issues

Fixes #

Automation tests

  • Unit tests added: Yes/No
  • Integration tests added: Yes/No

Tested environments

Tested Locally

Maintainers: Check before merge

  • Assigned 'Type' label
  • Assigned the project
  • Validated respective github issues
  • Assigned milestone to the github issue(s)

@renuka-fernando
Copy link
Contributor

Scenarios

https://excalidraw.com/#json=GSHjxOScbu_axA1TEke-z,waqWxYaRRK-QpsH02FrhSA

ws-internal-key-scenarios

@renuka-fernando
Copy link
Contributor

Shall we add some unit tests?

malinthaprasan
malinthaprasan previously approved these changes Aug 2, 2024
View reviewed changes
renuka-fernando
renuka-fernando previously approved these changes Aug 5, 2024
View reviewed changes
@Thushani-Jayasekera Thushani-Jayasekera dismissed renuka-fernando’s stale review August 5, 2024 13:06

The merge-base changed after approval.

@renuka-fernando renuka-fernando merged commit 56727c9 into wso2:choreo Aug 9, 2024
2 of 3 checks passed
@choreo-cicd
Copy link

[succeeded] Dataplane(EastUS) cluster : dev-deployment-v2 : 20240813.19

@choreo-cicd
Copy link

[succeeded] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20240813.19

@choreo-cicd
Copy link

[succeeded] : dev-deployment-v2 : 20240813.19

@choreo-cicd
Copy link

[succeeded] Controlplane cluster : stage-deployment-v2 : 20240815.3

@choreo-cicd
Copy link

[failed] Dataplane(NorthEU) cluster : stage-deployment-v2 : 20240815.3

@choreo-cicd
Copy link

[succeeded] Dataplane(CDP2-WU2) cluster : stage-deployment-v2 : 20240815.3

@choreo-cicd
Copy link

[succeeded] Dataplane(EastUS) cluster : stage-deployment-v2 : 20240815.3

@choreo-cicd
Copy link

[failed] Dataplane(NorthEU) cluster : stage-deployment-v2 : 20240815.4

@choreo-cicd
Copy link

[succeeded] Controlplane cluster : stage-deployment-v2 : 20240815.3

@choreo-cicd
Copy link

[failed] Dataplane(NorthEU) cluster : stage-deployment-v2 : 20240815.3

1 similar comment
@choreo-cicd
Copy link

[failed] Dataplane(NorthEU) cluster : stage-deployment-v2 : 20240815.3

@choreo-cicd
Copy link

[succeeded] Dataplane(CDP2-WU2) cluster : stage-deployment-v2 : 20240815.3

@choreo-cicd
Copy link

[succeeded] Dataplane(EastUS) cluster : stage-deployment-v2 : 20240815.3

@choreo-cicd
Copy link

[succeeded] Controlplane cluster : stage-deployment-v2 : 20240815.3

@choreo-cicd
Copy link

[] Controlplane cluster : stage-deployment-v2 : 20240815.5

@choreo-cicd
Copy link

[] Dataplane(NorthEU) cluster : stage-deployment-v2 : 20240815.5

@choreo-cicd
Copy link

[] Dataplane(CDP2-WU2) cluster : stage-deployment-v2 : 20240815.5

@choreo-cicd
Copy link

[] Dataplane(EastUS) cluster : stage-deployment-v2 : 20240815.5

@choreo-cicd
Copy link

[succeeded] Controlplane cluster : stage-deployment-v2 : 20240816.4

@choreo-cicd
Copy link

[succeeded] Dataplane(NorthEU) cluster : stage-deployment-v2 : 20240816.4

@choreo-cicd
Copy link

[succeeded] Dataplane(CDP2-WU2) cluster : stage-deployment-v2 : 20240816.4

@choreo-cicd
Copy link

[succeeded] Dataplane(NorthEU) cluster : prod-deployment-v2 : 20240820.3

@choreo-cicd
Copy link

[succeeded] Dataplane(CDP2-WU2) cluster : prod-deployment-v2 : 20240820.3

@choreo-cicd
Copy link

[succeeded] Dataplane(EastUS) cluster : prod-deployment-v2 : 20240820.3

@choreo-cicd
Copy link

[succeeded] Controlplane cluster : prod-deployment-v2 : 20240820.3

@choreo-cicd
Copy link

[] Dataplane(EastUS) cluster : prod-deployment-v2 : 20240820.4

@choreo-cicd
Copy link

[] Controlplane cluster : prod-deployment-v2 : 20240820.4

@choreo-cicd
Copy link

[] Dataplane(NorthEU) cluster : prod-deployment-v2 : 20240820.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renuka-fernando renuka-fernando renuka-fernando approved these changes

@malinthaprasan malinthaprasan malinthaprasan left review comments

Assignees
No one assigned
Labels
Status/DeployedToDev Status/DeployedToProd Status/DeployedToStage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Thushani-Jayasekera @renuka-fernando @choreo-cicd @malinthaprasan