-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert elligible PSD files to OpenRaster format #1
base: master
Are you sure you want to change the base?
Conversation
Hi Alex, Thanks for the effort, however I'd like to keep the psd files as well (for now). |
No worries, I'll check them back out and amend this commit. |
Okay, I've pushed an amended commit to this branch. My PR now has all previous PSD files along with OpenRaster conversions.
It's worth noting that the files do end up being converted, there is just loss of quality or features. For example, here's Wight.png PNG rendered from Photoshop (provided by Santi)GIMPNow here's Wight.psd as it appears in GIMP (or when converted to OpenRaster): The purple effect on the smoke in its hands is gone. GIMP has no support for layer styles whatsoever. This is what that layer looks like in GIMP: KritaKrita does support layer styles. When opening the PSD in Krita, it looks like this: As you can see, the effect is visible, but it's messed up. However, I noticed that setting choke to 100% mostly fixes the problem. That said, it is still not exactly the same. 😕 I think if we decide to do this, we should update the PNG version so at least it can be generated by the file. Also, importantly, neither xcf nor ora supports this. In this case, we would have to distribute the kra, which is Krita's file format. It's quite similar to OpenRaster but it's not widely supported (GIMP can't open it, for instance, but GIMP also doesn't support layer styles) and not ideal as an interchange format for the same reason xcf isn't. Still better than PSD in my opinion, because at least you can open the kra with Krita (free/libre software) and it looks right, while you cannot with the PSD. I'd be fine distributing .kra files in places where OpenRaster doesn't work. Hopefully the OpenRaster spec will catch up to kra over time. Thoughts?
I'm not convinced this is relevant yet. Layer styles have been around since at least Photoshop 6 (2000) so it's probably a coincidence that Santi has been recently utilizing them. I will investigate the other documents and see where the incompatibilities lie. |
Writing up my findings a bit more. Using this command (stackoverflow) I can diff two PNGs to compare them.
So, I have First off, I tried exporting ORA to PNG with GIMP, and the PNG output was very different than the Photoshop PNG. Red pixels mean there is a change between the two versions. Ignore the faint image in the background, it's there only for reference. At first I was really scared. Did converting to OpenRaster totally fuck up the images? No. I exported the OpenRaster to PNG with Krita instead, and diff'd them again. Here's the output of that. This looks much better. Moral of the story: do not use GIMP to export PNG, use Krita. At least for GIMP 2.8. The problem, it seems, is that GIMP samples the hidden background layer when rendering semi-transparent pixels. Krita properly ignores it.
|
Hi Alex,
That's quite an impressive analysis you've made. I guess bottom line is
that we could offer the open raster format next to the psd files.
I'd opt to use the png's exported by Santi, and not the once's we export
form gimp/krita or so. I don't mind to much that the our offered png files
are not 100% exportable from the converted .ora files.
That is think we offer quite enough when we have a psd and ora file and a
sample png export.
To bad Q_x / Lucaz quite long before I even joined the wtactics project.
You guys would have very nice discussions about all these things :-)
In the end we had to be a bit practical about the cards/artwork cause we
were doing it a bit to perfect, and in the end nothing got made.
That's one of the main reasons I started arcmage, to not lose track of the
objective: create a playable hobby card game. Come up with something and
improve along the way.
Anyway I appreciate all the work and thought you put in this.
Btw, I also upgraded the wiki software, there was a bug in the version we
were using. It made that you couldn't change your password at first login.
I requested a password reset for your account, so you should get an email.
(could end up in your spam account)
Let me know if you can login to the wiki.
Kind regards,
Nico
…On Tue, May 8, 2018 at 7:44 PM, Alex Gleason ***@***.***> wrote:
Writing up my findings a bit more.
Using this command (stackoverflow
<https://stackoverflow.com/questions/5132749/diff-an-image-using-imagemagick>)
I can diff two PNGs to compare them.
compare image1 image2 -compose src diff.png
So, I have Band Of Brothers.ora and Band Of Brothers.png. I'll convert
the OpenRaster to a PNG then compare them.
First off, I tried exporting ORA to PNG with GIMP, and the PNG output was
very different than the Photoshop PNG.
[image: bob-gimp-diff]
<https://user-images.githubusercontent.com/3639540/39772144-691ef632-52c2-11e8-9189-37a91c867e3b.png>
Red pixels mean *there is a change between the two versions.* Ignore the
faint image in the background, it's there only for reference.
At first I was really scared. Did converting to OpenRaster totally fuck up
the images? No. I exported the OpenRaster to PNG with Krita instead, and
diff'd them again. Here's the output of that.
[image: bob-diff]
<https://user-images.githubusercontent.com/3639540/39772208-954113d0-52c2-11e8-8e47-d939506a9029.png>
There are no red pixels, which means that the OpenRaster and the Photoshop
PNG are *identical*.
Moral of the story: *do not use GIMP to export PNG, use Krita*. At least
for GIMP 2.8. The problem, it seems, is that GIMP samples the hidden
background layer when rendering semi-transparent pixels. Krita properly
ignores it.
Anyway, so we can use this tool to verify that *the OpenRaster file is in
fact identical to the PSD.* This is great, our conversion worked fine!
Next, we can use this on the files with errors.
Here's *Orc Fortress*, which gave the error: convertAndSetBlendMode:
Curve conversion is not implemented yet
[image: orc-diff]
<https://user-images.githubusercontent.com/3639540/39772505-73ffcd78-52c3-11e8-8fe3-e121adac4fd2.png>
If you look closely, there are some very small red dots.
[image: screenshot from 2018-05-08 13 27 19]
<https://user-images.githubusercontent.com/3639540/39772542-8daef88e-52c3-11e8-9eaf-4da6f1b15860.png>
I actually have no clue what's causing this. The two images look identical
to the naked eye, so I'm not concerned at all about these pixels. I think
we can safely adopt the OpenRaster file for this one.
On *Centaur Staff* there's something wrong with the lettering:
[image: staff-diff]
<https://user-images.githubusercontent.com/3639540/39772947-8e7b7c82-52c4-11e8-995d-3aacde617c6b.png>
Comparing the images side-by-side you can see it's clearly the beveling
(original version is on the right):
[image: screenshot from 2018-05-08 13 35 03]
<https://user-images.githubusercontent.com/3639540/39772988-b02dd352-52c4-11e8-9749-3a24d4471ff4.png>
The original version has a *Bevel and Emboss* layer style which is
removed in the ora. Like with Wight, Krita will render it (for a kra file),
but it's all messed up and needs to be adjusted.
Here's Krita doing an ugly job at rendering the layer style:
[image: screenshot from 2018-05-08 13 40 31]
<https://user-images.githubusercontent.com/3639540/39773243-6e2ac978-52c5-11e8-9f06-b44df6cdc45e.png>
I might do more later, but my hunch is that most of these problems will be
issues with layer styles.
Some of these files we'll be able to convert and forget it, but some we'll
have to adjust the layer styles in Krita and then provide a .kra, I think.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AQyVznjcK08N9C80OqaoHs6KJDl6n_r8ks5twdmEgaJpZM4T0RQk>
.
|
ora format would be nice indeed. Krita is really amazing and proprietary stuff like PS/psd needs to be avoided as much as possible (if not forgotten, but I'm being idealistic here). Been trying to download the whole repo as a zip but that failed me a few times, so I had to clone it (which is way more nerdy), so if including psd source files along with ora, it would get way larger. |
I think that .ora is a better format to distribute this artwork in than PSD wherever possible. ora (OpenRaster) is a libre interchange format that is easy to implement and is supported by a number of digital image programs like GIMP and Krita.
I wrote a script (using Krita) to convert all the .psd files in the WT directory into .ora format:
Most of the files converted seamlessly with no issues. Here's the full log:
These 12 files did have issues:
./Orc Fortress/Orc Fortress.psd
./Centaur Staff/Centaur Staff.psd
./Wight/Wight.psd
./Squad Leader/Squad Leader.psd
./Conscript/Conscript.psd
./Nightbird Bow/Nightbird Bow.psd
./Mentor/Mentor.psd
./Bracer Of The Octopus/Bracer Of The Octopus.psd
./Goblin Sacred Place/Goblin Sacred Place.psd
./Mercenary/Mercenary.psd
./Ink Cloud/Ink Cloud.psd
./Fire Wizard Female/Fire Wizard Female.psd
The issues all seemed related to the fact that they use Photoshop blend modes which are not compatible with free software like GIMP or Krita. Even with .xcf or .kra I could not convert these files accurately. Therefore, I left these 12 files as .PSD format for now.
So, I only converted the files to .ora where full support exists, and I left the unsupported files as psd for now.