Krakatoa/build: Generate new RSA keys for every container build #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the static assets `build.rsa` and `build.rsa.pub` from the repository and replaces them with a single use key that exists for that container image only. This change is being done to reduce risk and encourage new best practice. In the future we will delete the private key after the build completes, thus preventing any more packages from being signed again. This could be grown to make a secure remote repository too. CHANGES: Containerfile: * Remove manual copy of build.rsa.pub to the /etc/apk/keys directory. * Add a call to abuild-keygen after switching to the `build` user. home/build/abuild/abuild.conf: * Add PACKAGER="wtfbbqhax/Krakatoa" home/build/abuild/build.rsa: * Deleted home/build/abuild/build.rsa.pub * Deleted This will allow me to possiblyand keep a really tight leash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the static assets
build.rsaandbuild.rsa.pubfrom the repository and replaces them with a single use key that exists for that container image only.This change is being done to reduce risk and encourage new best practice. In the future we will delete the private key after the build completes, thus preventing any more packages from being signed again.
This could be grown to make a secure remote repository too.
CHANGES:
Containerfile:
Remove manual copy of build.rsa.pub to the /etc/apk/keys directory.
Add a call to abuild-keygen after switching to the
builduser.home/build/abuild/abuild.conf:
home/build/abuild/build.rsa:
home/build/abuild/build.rsa.pub