Skip to content

Conversation

@jensneuse
Copy link
Member

No description provided.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 31, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/add-caching-support

Comment @coderabbitai help to get the list of available commands and usage tips.

@jensneuse jensneuse changed the title chore: add ProvidesData + tests feat: add caching to loader Aug 1, 2025
@jensneuse
Copy link
Member Author

jensneuse commented Aug 5, 2025

TODO:

  1. ability for Router to provide a key prefix, e.g. from authorization header
  2. for root fields, we should render all root field names into the key, otherwise root fields won't work
  3. skip mutations
  4. allow partial cache hits
  5. fix case when some keys render to empty string
  6. mix of keys and args

…ching-support

# Conflicts:
#	v2/pkg/engine/plan/configuration.go
#	v2/pkg/engine/plan/visitor.go
#	v2/pkg/engine/resolve/loader.go
#	v2/pkg/engine/resolve/resolve.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants