Fix missing dependencies and instructions to run demo_to_gdict script#26
Open
pthangeda wants to merge 1 commit intowuphilipp:mainfrom
Open
Fix missing dependencies and instructions to run demo_to_gdict script#26pthangeda wants to merge 1 commit intowuphilipp:mainfrom
pthangeda wants to merge 1 commit intowuphilipp:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #25, running
demo_to_gdict.pywill lead to a series of errors due to missinggdictandsimple_bcmodules ingello/data_utilsand also because of a few other required dependencies.This PR adds
gdictandsimple_bcmodules otdata_utilsand also adds arequirements_data_process.txtwith all the required Python packages to rundemo_to_gdict.py. The README is also updated with the instructions to install these dependencies before running the processing script.