Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert modal #808

Merged
merged 10 commits into from
Oct 21, 2024
Merged

Convert modal #808

merged 10 commits into from
Oct 21, 2024

Conversation

3lviend
Copy link
Collaborator

@3lviend 3lviend commented Oct 8, 2024

Issue #738

Convert modal using dialog:
dialog

modal update:
image
image
image
image

@3lviend 3lviend marked this pull request as ready for review October 10, 2024 07:37
@tadast
Copy link
Collaborator

tadast commented Oct 10, 2024

image

Looks like the tooltips for sequence viewer modal are no longer working. Above is an example from main branch, on this branch the position tooltip is not shown and I can see the DOM has undefined strings as IDs.

Other than that looks good to me, the modals are now better sized and I can close them by hitting esc 🙌

@tadast tadast merged commit 14a8936 into master Oct 21, 2024
4 of 5 checks passed
@tadast tadast deleted the convert-modal branch October 21, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants