Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use directory name when zip.name and package.json#name are not provided #1028

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

aklinker1
Copy link
Collaborator

Copy link

netlify bot commented Oct 3, 2024

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit c668582
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/66fed0f559ec270008a7d9d5
😎 Deploy Preview https://deploy-preview-1028--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Oct 3, 2024

Open in Stackblitz

@wxt-dev/auto-icons

pnpm add https://pkg.pr.new/@wxt-dev/auto-icons@1028

@wxt-dev/module-react

pnpm add https://pkg.pr.new/@wxt-dev/module-react@1028

@wxt-dev/i18n

pnpm add https://pkg.pr.new/@wxt-dev/i18n@1028

@wxt-dev/module-svelte

pnpm add https://pkg.pr.new/@wxt-dev/module-svelte@1028

@wxt-dev/module-solid

pnpm add https://pkg.pr.new/@wxt-dev/module-solid@1028

@wxt-dev/module-vue

pnpm add https://pkg.pr.new/@wxt-dev/module-vue@1028

wxt

pnpm add https://pkg.pr.new/wxt@1028

commit: c668582

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.98%. Comparing base (d75f64d) to head (c668582).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1028      +/-   ##
==========================================
- Coverage   82.21%   81.98%   -0.23%     
==========================================
  Files         127      127              
  Lines        6633     6635       +2     
  Branches     1104     1104              
==========================================
- Hits         5453     5440      -13     
- Misses       1166     1181      +15     
  Partials       14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aklinker1 aklinker1 marked this pull request as ready for review October 3, 2024 17:26
@aklinker1 aklinker1 merged commit ab26bdc into main Oct 3, 2024
18 checks passed
@aklinker1 aklinker1 deleted the fix-zip-name-fallback branch October 3, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant