Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌟 Implemented a way for users to define the output entrypoint name #1304

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

SamHoque
Copy link

Additional changes:

  • Added author field to manifest
  • Implemented recursive finding of package.json

check #1302

Additional changes:
- Added author field to manifest
- Implemented recursive finding of package.json
Copy link

netlify bot commented Dec 25, 2024

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 623cc3d
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/676b8fa52c4ea0000803fd64
😎 Deploy Preview https://deploy-preview-1304--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aklinker1
Copy link
Collaborator

aklinker1 commented Dec 25, 2024

I don't want to add the ability to add hashes to filenames. This is because in my experience, changing filenames between submissions to the Chrome Web Store and Firefox Addon Store results in longer review times and more manual reviews. My guess is that the diff tools they use don't work well with renamed files, so these submissions get flagged more often.

As for your other two changes...

  • Added author field to manifest

Can you open a separate PR for this?

  • Implemented recursive finding of package.json

What is the point of this? What's your use-case for not having a package.json in your extension's root directory?

@aiktb
Copy link
Contributor

aiktb commented Dec 25, 2024

https://developer.chrome.com/docs/extensions/reference/manifest/author

Adding the Author field will break a lot of extensions, it MUST match the email of the Google account that published the extension.

Even if this doesn't break anything, I don't understand the point of it since the Author field doesn't seem to be displayed anywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants