feat: Custom types package based on @types/chrome
#1332
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 0.20.0-breaking-changes #1332 +/- ##
===========================================================
+ Coverage 81.23% 81.34% +0.10%
===========================================================
Files 127 127
Lines 6245 6244 -1
Branches 1045 1046 +1
===========================================================
+ Hits 5073 5079 +6
+ Misses 1155 1148 -7
Partials 17 17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aleclarson
reviewed
Feb 8, 2025
| @@ -67,7 +67,11 @@ function getMessageSenderUrl(sender: browser.runtime.MessageSender): string { // | |||
| } | |||
| ``` | |||
|
|
|||
| `@types/chrome` are more up-to-date, contain less bugs, and don't have any auto-generated names. So even if you continue to use the polyfill, you will need to update your types to use these types. | |||
| `@types/chrome` are more up-to-date and contain less bugs, but not all types do not have the same names. You will have to find the equivalent types in `@types/chrome` that you were using before. | |||
There was a problem hiding this comment.
but not all types do not have the same names
Double negative is confusing :)
There was a problem hiding this comment.
I've rewritten this upgrade guide so many times.... Not surprising I missed something like this. Should be a single negative
|
Closed in favor of #1530 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.