Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Bump unjs ecosystem #1508

Merged
merged 2 commits into from
Mar 19, 2025
Merged

Conversation

lishaduck
Copy link
Contributor

@lishaduck lishaduck commented Mar 8, 2025

Overview

Following https://antfu.me/posts/move-on-to-esm-only, the unjs ecosystem is now ESM only.
This means that we need to extend our range of supported package versions.

Notably, I didn't upgrade ohash, because v2 removes murmur in favor of digest. (Which is ironic, because that's why I started this PR).

Other notes:

Manual Testing

Shouldn't be needed, these are all just ESM-only migrations.

Related Issue

None

Following https://antfu.me/posts/move-on-to-esm-only,
the unjs ecosystem is now ESM only.
This means that we need to extend our range of supported package versions.
Copy link

netlify bot commented Mar 8, 2025

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 8438394
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/67cd024221ae910008c2d42f
😎 Deploy Preview https://deploy-preview-1508--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lishaduck
Copy link
Contributor Author

Shouldn't be needed, these are all just ESM-only migrations.

I take that back, nypm now supports Deno, and the way we're using nypm makes that a breaking change.
I gave a shot at updating, but Deno's so different I don't know how we want to handle it.

Copy link
Collaborator

@aklinker1 aklinker1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I take that back, nypm now supports Deno, and the way we're using nypm makes that a breaking change.
I gave a shot at updating, but Deno's so different I don't know how we want to handle it.

Yeah, Deno is too different from the rest of the JS ecosystem, you can kinda use it in a project, but it's hard: #1307

The NYPM stuff is definitely problematic for it :/

Copy link

pkg-pr-new bot commented Mar 13, 2025

Open in Stackblitz

@wxt-dev/analytics

npm i https://pkg.pr.new/@wxt-dev/analytics@1508

@wxt-dev/auto-icons

npm i https://pkg.pr.new/@wxt-dev/auto-icons@1508

@wxt-dev/i18n

npm i https://pkg.pr.new/@wxt-dev/i18n@1508

@wxt-dev/module-react

npm i https://pkg.pr.new/@wxt-dev/module-react@1508

@wxt-dev/module-solid

npm i https://pkg.pr.new/@wxt-dev/module-solid@1508

@wxt-dev/module-svelte

npm i https://pkg.pr.new/@wxt-dev/module-svelte@1508

@wxt-dev/module-vue

npm i https://pkg.pr.new/@wxt-dev/module-vue@1508

@wxt-dev/storage

npm i https://pkg.pr.new/@wxt-dev/storage@1508

@wxt-dev/unocss

npm i https://pkg.pr.new/@wxt-dev/unocss@1508

wxt

npm i https://pkg.pr.new/wxt@1508

commit: 8438394

@aklinker1 aklinker1 changed the title Bump unjs ecosystem chore(deps): Bump unjs ecosystem Mar 19, 2025
@aklinker1 aklinker1 merged commit 17fd2ff into wxt-dev:main Mar 19, 2025
16 checks passed
Copy link
Contributor

Thanks for helping make WXT better!

@lishaduck lishaduck deleted the bump-unjs branch March 19, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants