-
-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): Bump unjs ecosystem #1508
Conversation
Following https://antfu.me/posts/move-on-to-esm-only, the unjs ecosystem is now ESM only. This means that we need to extend our range of supported package versions.
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I take that back, nypm now supports Deno, and the way we're using nypm makes that a breaking change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I take that back, nypm now supports Deno, and the way we're using nypm makes that a breaking change.
I gave a shot at updating, but Deno's so different I don't know how we want to handle it.
Yeah, Deno is too different from the rest of the JS ecosystem, you can kinda use it in a project, but it's hard: #1307
The NYPM stuff is definitely problematic for it :/
@wxt-dev/analytics
@wxt-dev/auto-icons
@wxt-dev/i18n
@wxt-dev/module-react
@wxt-dev/module-solid
@wxt-dev/module-svelte
@wxt-dev/module-vue
@wxt-dev/storage
@wxt-dev/unocss
wxt
commit: |
Thanks for helping make WXT better! |
Overview
Following https://antfu.me/posts/move-on-to-esm-only, the unjs ecosystem is now ESM only.
This means that we need to extend our range of supported package versions.
Notably, I didn't upgrade ohash, because v2 removes
murmur
in favor ofdigest
. (Which is ironic, because that's why I started this PR).Other notes:
[email protected]
#1501 will also help with this, as buildc is also pulling in old unjs versions (but only internally, of course).import-meta-resolve
calledexsolve
. I'd leave that for another PR.Manual Testing
Shouldn't be needed, these are all just ESM-only migrations.
Related Issue
None