Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add subdependency bin directory so wxt build --analyze works with PNPM #363

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

aklinker1
Copy link
Collaborator

This closes #360

@aklinker1 aklinker1 added the bug Something isn't working label Jan 19, 2024
@aklinker1 aklinker1 self-assigned this Jan 19, 2024
Copy link

netlify bot commented Jan 19, 2024

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit d2e018d
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/65aab046f15b410009651f69
😎 Deploy Preview https://deploy-preview-363--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a525d78) 81.06% compared to head (d2e018d) 80.68%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #363      +/-   ##
==========================================
- Coverage   81.06%   80.68%   -0.39%     
==========================================
  Files         103      103              
  Lines        7267     7273       +6     
  Branches      658      657       -1     
==========================================
- Hits         5891     5868      -23     
- Misses       1360     1389      +29     
  Partials       16       16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aklinker1 aklinker1 merged commit 9ace395 into main Jan 19, 2024
17 checks passed
@aklinker1 aklinker1 deleted the pnpm-analyze-fix branch January 19, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build --analyze doesn't work with pnpm
1 participant