avoid caching old assets preserved by sprockets #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a note about this: I've found that I have to sort by mtime to get the latest assets on heroku, even though sprockets picks the previous assets to keep based on ctime. This seems to happen because heroku appears to retain more than 3 copies of an asset for some reason, and manages to update the ctime of those stale assets to boot (all on rails4, fwiw). |
…n 3 assets behind while updating their mtimes despite sprockets claim to remove all but 3 copies
… with different fingerprints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because sprockets by default leaves around the 2 previous copies of any assets, the default behavior of rack-offline.rb for rails is to cache three times the necessary data. This code picks only the latest file (based on ctime) and adds that to the manifest. Wasn't sure if this warranted testing since there is no corresponding test for rack-offline.