Remove aria-describedby link between labels/legends and supplemental content
#580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes the aria-describedby link between labels/legends and supplemental content, and the warnings that were added in #456. It still allows arbitrary HTML content to be passed in, and it'll be rendered in the same place - but importantly, it won't be read out by screen readers. This can be a frustrating experience for screenr eader users if there's multiple paragraphs read out between the label and the input itself. Fixes #445.
✅ Deploy Preview for govuk-form-builder ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the aria-describedby link between labels/legends and supplemental content, and the warnings that were added in #456.
It still allows arbitrary HTML content to be passed in, and it'll be rendered in the same place - but importantly, now it won't be read out by screen readers. This can be a frustrating experience for screenr eader users if there's multiple paragraphs read out between the label and the input itself.